Reload property sources when new property gets added. (#807)

Fixes #803

Author: maciejwalkowiak

spring-cloud-aws-autoconfigure/src/main/java/io/awspring/cloud/autoconfigure/config/reload/ConfigurationChangeDetector.java

@@ -16,6 +16,7 @@
 package io.awspring.cloud.autoconfigure.config.reload;
 
 import io.awspring.cloud.core.config.AwsPropertySource;
+import java.util.Arrays;
 import java.util.List;
 import java.util.Objects;
 import java.util.stream.Collectors;
@@ -68,6 +69,13 @@ protected boolean changed(EnumerablePropertySource<?> left, EnumerablePropertySo
 		if (left == right) {
 			return false;
 		}
+
+		// check if a new property is added
+		if (!Arrays.equals(left.getPropertyNames(), right.getPropertyNames())) {
+			return true;
+		}
+
+		// check if a value of existing property changed
 		for (String property : left.getPropertyNames()) {
 			if (!Objects.equals(left.getProperty(property), right.getProperty(property))) {
 				return true;

spring-cloud-aws-autoconfigure/src/test/java/io/awspring/cloud/autoconfigure/config/parameterstore/ParameterStoreConfigDataLoaderIntegrationTests.java

@@ -227,7 +227,7 @@ void resetParameterValue() {
 		}
 
 		@Test
-		void reloadsProperties() {
+		void reloadsPropertiesWhenPropertyValueChanges() {
 			SpringApplication application = new SpringApplication(App.class);
 			application.setWebApplicationType(WebApplicationType.NONE);
 
@@ -252,6 +252,32 @@ void reloadsProperties() {
 			}
 		}
 
+		@Test
+		void reloadsPropertiesWhenNewPropertyIsAdded() {
+			SpringApplication application = new SpringApplication(App.class);
+			application.setWebApplicationType(WebApplicationType.NONE);
+
+			try (ConfigurableApplicationContext context = application.run(
+					"--spring.config.import=aws-parameterstore:/config/spring/",
+					"--spring.cloud.aws.parameterstore.reload.strategy=refresh",
+					"--spring.cloud.aws.parameterstore.reload.period=PT1S",
+					"--spring.cloud.aws.parameterstore.region=" + REGION,
+					"--spring.cloud.aws.endpoint=" + localstack.getEndpointOverride(SSM).toString(),
+					"--spring.cloud.aws.credentials.access-key=noop", "--spring.cloud.aws.credentials.secret-key=noop",
+					"--spring.cloud.aws.region.static=eu-west-1")) {
+				assertThat(context.getEnvironment().getProperty("message")).isEqualTo("value from tests");
+
+				// update parameter value
+				SsmClient ssmClient = context.getBean(SsmClient.class);
+				ssmClient.putParameter(r -> r.name("/config/spring/new-property").value("new value")
+						.type(ParameterType.STRING).overwrite(true).build());
+
+				await().atMost(Duration.ofSeconds(5)).untilAsserted(() -> {
+					assertThat(context.getEnvironment().getProperty("new-property")).isEqualTo("new value");
+				});
+			}
+		}
+
 		@Test
 		void doesNotReloadPropertiesWhenReloadStrategyIsNotSet() {
 			SpringApplication application = new SpringApplication(App.class);