Skip to content

Commit 9732210

Browse files
committed
feat: add null check for batchManager in BatchingSqsClientAdapter constructor
1 parent 2fa68f7 commit 9732210

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

spring-cloud-aws-sqs/src/main/java/io/awspring/cloud/sqs/operations/BatchingSqsClientAdapter.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ public class BatchingSqsClientAdapter implements SqsAsyncClient {
1111
private final SqsAsyncBatchManager batchManager;
1212

1313
public BatchingSqsClientAdapter(SqsAsyncBatchManager batchManager) {
14+
Assert.notNull(batchManager, "batchManager cannot be null");
1415
this.batchManager = batchManager;
1516
}
1617

spring-cloud-aws-sqs/src/test/java/io/awspring/cloud/sqs/operations/BatchingSqsClientAdapterTests.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
import java.util.function.Consumer;
3030

3131
import static org.assertj.core.api.Assertions.assertThat;
32+
import static org.assertj.core.api.Assertions.assertThatThrownBy;
3233
import static org.mockito.ArgumentMatchers.any;
3334
import static org.mockito.BDDMockito.given;
3435
import static org.mockito.BDDMockito.then;
@@ -49,6 +50,13 @@ void beforeEach() {
4950
mockAdapter = new BatchingSqsClientAdapter(mockBatchManager);
5051
}
5152

53+
@Test
54+
void shouldThrowExceptionWhenBatchManagerIsNull() {
55+
assertThatThrownBy(() -> new BatchingSqsClientAdapter(null))
56+
.isInstanceOf(IllegalArgumentException.class)
57+
.hasMessage("batchManager cannot be null");
58+
}
59+
5260
@Test
5361
void shouldReturnCorrectServiceName() {
5462
String serviceName = mockAdapter.serviceName();

0 commit comments

Comments
 (0)