Skip to content

Commit c752dd1

Browse files
authored
Move testcontainers dependency (#759)
Currently, `org.testcontainers:testcontainers-bom` is part of the spring-cloud-aws-dependencies which is imported in a consumer project when the dependency is declared. The version provided by that module is forced and can not be overriden. For that reason, this PR suggest to move the dependency from that module.
1 parent 8f6b560 commit c752dd1

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

pom.xml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
<spotless.version>2.31.0</spotless.version>
3131
<jacoco.version>0.8.8</jacoco.version>
3232
<maven-gpg-plugin.version>1.6</maven-gpg-plugin.version>
33+
<testcontainers.version>1.18.0</testcontainers.version>
3334
</properties>
3435

3536
<modules>
@@ -66,6 +67,13 @@
6667
<type>pom</type>
6768
<scope>import</scope>
6869
</dependency>
70+
<dependency>
71+
<groupId>org.testcontainers</groupId>
72+
<artifactId>testcontainers-bom</artifactId>
73+
<version>${testcontainers.version}</version>
74+
<type>pom</type>
75+
<scope>import</scope>
76+
</dependency>
6977
</dependencies>
7078
</dependencyManagement>
7179

spring-cloud-aws-dependencies/pom.xml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
<amazon.dax.version>2.0.3</amazon.dax.version>
3030
<maven-gpg-plugin.version>1.6</maven-gpg-plugin.version>
3131
<spring-cloud-commons.version>4.0.1</spring-cloud-commons.version>
32-
<testcontainers.version>1.18.0</testcontainers.version>
3332
<jakarta.mail.version>2.1.0</jakarta.mail.version>
3433
<eclipse.jakarta.mail.version>1.0.0</eclipse.jakarta.mail.version>
3534
<aws-crt.version>0.21.9</aws-crt.version>
@@ -53,14 +52,6 @@
5352
<scope>import</scope>
5453
</dependency>
5554

56-
<dependency>
57-
<groupId>org.testcontainers</groupId>
58-
<artifactId>testcontainers-bom</artifactId>
59-
<version>${testcontainers.version}</version>
60-
<type>pom</type>
61-
<scope>import</scope>
62-
</dependency>
63-
6455
<dependency>
6556
<groupId>software.amazon.dax</groupId>
6657
<artifactId>amazon-dax-client</artifactId>

0 commit comments

Comments
 (0)