Make S3Client in S3Template protected

[Tooa]

Making the S3Client protected allows you to define Kotlin extension methods adding new functionality. This is useful to add methods like copy (#1157) to the S3Template.

Update: Visibility protected is not enough. It has to be public (Documentaion). We would have to add a getter for the S3Client field.

@maciejwalkowiak would you be open for this change?

[maciejwalkowiak]

Hi @Tooa. I am afraid this opens doors to making everything everywhere public that I would not like to do.

[Tooa]

Yes, this is a fair concern. Will close this discussion then. Thank you for taking the time looking into this.

I will provide some RFC pull requests extending the S3Template with IMHO useful functions if time allows for it.

[maciejwalkowiak]

Yes please. We can add more methods to S3Template if needed.