Fix validity checks for UD types

awulkiew · awulkiew · commit 45e163b4c461 · 2023-05-18T12:30:05.000+02:00
diff --git a/Visual_Studio_2017/GraphicalDebugging/ExpressionLoader_UserDefined.cs b/Visual_Studio_2017/GraphicalDebugging/ExpressionLoader_UserDefined.cs
@@ -480,6 +480,7 @@ public UserSimpleGeometry(Loaders loaders, Debugger debugger,
                 if (ExpressionParser.IsInvalidSize(sizeOf))
                     return;
 
+                bool allValid = true;
                 if (pointExprs != null)
                 {
                     pointMembers = new UserPointMember[pointExprs.Length];
@@ -489,7 +490,7 @@ public UserSimpleGeometry(Loaders loaders, Debugger debugger,
                                                               name, type,
                                                               sizeOf, pointExprs[i]);
                         if (!pointMembers[i].IsValid)
-                            return;
+                            allValid = false;
                     }
                 }
                 
@@ -502,13 +503,13 @@ public UserSimpleGeometry(Loaders loaders, Debugger debugger,
                                                               name, type,
                                                               sizeOf, valueExprs[i]);
                         if (!valueMembers[i].IsValid)
-                            return;
+                            allValid = false;
                     }
                 }
                 
                 this.traits = traits;
 
-                IsValid = true;
+                IsValid = allValid;
             }
             
             public Geometry.Traits GetTraits(MemoryReader mreader, Debugger debugger,

Original file line number	Diff line number	Diff line change
`@@ -480,6 +480,7 @@ public UserSimpleGeometry(Loaders loaders, Debugger debugger,`
`480`	`480`	`if (ExpressionParser.IsInvalidSize(sizeOf))`
`481`	`481`	`return;`
`482`	`482`
	`483`	`+ bool allValid = true;`
`483`	`484`	`if (pointExprs != null)`
`484`	`485`	`{`
`485`	`486`	`pointMembers = new UserPointMember[pointExprs.Length];`
`@@ -489,7 +490,7 @@ public UserSimpleGeometry(Loaders loaders, Debugger debugger,`
`489`	`490`	`name, type,`
`490`	`491`	`sizeOf, pointExprs[i]);`
`491`	`492`	`if (!pointMembers[i].IsValid)`
`492`		`- return;`
	`493`	`+ allValid = false;`
`493`	`494`	`}`
`494`	`495`	`}`
`495`	`496`
`@@ -502,13 +503,13 @@ public UserSimpleGeometry(Loaders loaders, Debugger debugger,`
`502`	`503`	`name, type,`
`503`	`504`	`sizeOf, valueExprs[i]);`
`504`	`505`	`if (!valueMembers[i].IsValid)`
`505`		`- return;`
	`506`	`+ allValid = false;`
`506`	`507`	`}`
`507`	`508`	`}`
`508`	`509`
`509`	`510`	`this.traits = traits;`
`510`	`511`
`511`		`- IsValid = true;`
	`512`	`+ IsValid = allValid;`
`512`	`513`	`}`
`513`	`514`
`514`	`515`	`public Geometry.Traits GetTraits(MemoryReader mreader, Debugger debugger,`