Skip to content

Commit a15736e

Browse files
committed
Add comments for UD Array and LinkedList loaders.
1 parent bebde89 commit a15736e

File tree

1 file changed

+16
-1
lines changed

1 file changed

+16
-1
lines changed

Visual_Studio_2017/GraphicalDebugging/ExpressionLoader_UserDefined.cs

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,14 @@ namespace GraphicalDebugging
1818
{
1919
partial class ExpressionLoader
2020
{
21-
// TODO: Use in UserArrayEntry
21+
// TODO: Storing elemType is not correct because the same loader
22+
// can potentially be used for two different container types storing
23+
// different elements.
24+
// This is not a problem now because before that happens Initialize()
25+
// is called each time the loader is retrieved from the list of loaders.
26+
// This however should probably be changed because it's not efficient to
27+
// initialize loaders and call the debugger multiple times for the same type.
28+
2229
// TODO: The code is similar to std::vector loader, unify if possible
2330
class UserArray : ContiguousContainer
2431
{
@@ -69,6 +76,14 @@ public override int LoadSize(Debugger debugger, string name)
6976
string elemType;
7077
}
7178

79+
// TODO: Storing elemType is not correct because the same loader
80+
// can potentially be used for two different container types storing
81+
// different elements.
82+
// This is not a problem now because before that happens Initialize()
83+
// is called each time the loader is retrieved from the list of loaders.
84+
// This however should probably be changed because it's not efficient to
85+
// initialize loaders and call the debugger multiple times for the same type.
86+
7287
// TODO: The code is similar to std::list loader, unify if possible
7388
class UserLinkedList : ContainerLoader
7489
{

0 commit comments

Comments
 (0)