libSplash 1.7.0: readAttribute(Info)

refactor deprecated legacy attribute read API with new
API.

Reference:
  ComputationalRadiationPhysics/libSplash#248

Author: ax3l

include/picongpu/plugins/hdf5/HDF5Writer.hpp

@@ -448,7 +448,7 @@ class HDF5Writer :
 
         /* load number of slides to initialize MovingWindow */
         uint32_t slides = 0;
-        mThreadParams.dataCollector->readAttribute(restartStep, nullptr, "sim_slides", &slides);
+        mThreadParams.dataCollector->readAttributeInfo(restartStep, nullptr, "sim_slides").read(&slides, sizeof(slides));
 
         /* apply slides to set gpus to last/written configuration */
         log<picLog::INPUT_OUTPUT > ("HDF5 setting slide count for moving window to %1%") % slides;

include/picongpu/plugins/hdf5/NDScalars.hpp

@@ -120,7 +120,7 @@ struct ReadNDScalars
         if(!attrName.empty())
         {
             log<picLog::INPUT_OUTPUT>("HDF5: read attribute %1% for scalars: %2%") % attrName % name;
-            params.dataCollector->readAttribute(params.currentStep, name.c_str(), attrName.c_str(), attribute);
+            params.dataCollector->readAttributeInfo(params.currentStep, name.c_str(), attrName.c_str()).read(attribute, sizeof(T_Attribute));
             log<picLog::INPUT_OUTPUT>("HDF5: attribute %1% = %2%") % attrName % *attribute;
         }
     }

src/tools/splash2txt/tools_splash_parallel.cpp

@@ -232,8 +232,7 @@ void ToolsSplashParallel::convertToText()
     DomainCollector::DomDataClass ref_data_class = DomainCollector::UndefinedType;
     try
     {
-        dc.readAttribute(m_options.step, m_options.data[0].c_str(), DOMCOL_ATTR_CLASS,
-                &ref_data_class, nullptr);
+        dc.readAttributeInfo(m_options.step, m_options.data[0].c_str(), DOMCOL_ATTR_CLASS).read(&ref_data_class, sizeof(ref_data_class));
     } catch (const DCException&)
     {
         errorStream << "Error: No domain information for dataset '" << m_options.data[0] << "' available." << std::endl;
@@ -265,8 +264,7 @@ void ToolsSplashParallel::convertToText()
         //
 
         DomainCollector::DomDataClass data_class = DomainCollector::UndefinedType;
-        dc.readAttribute(m_options.step, iter->c_str(), DOMCOL_ATTR_CLASS,
-                &data_class, nullptr);
+        dc.readAttributeInfo(m_options.step, iter->c_str(), DOMCOL_ATTR_CLASS).read(&data_class, sizeof(data_class));
         if (data_class != ref_data_class)
             throw std::runtime_error("All requested datasets must be of the same data class");
 
@@ -311,8 +309,7 @@ void ToolsSplashParallel::convertToText()
         {
             try
             {
-                dc.readAttribute(m_options.step, iter->c_str(), "unitSI",
-                        &(excontainer.unit), nullptr);
+                dc.readAttribute(m_options.step, iter->c_str(), "unitSI").read(&(excontainer.unit), sizeof(excontainer.unit));
             } catch (const DCException&)
             {
                 if (m_options.verbose)