Axel can't handle CJK characters in content-disposition header correctly

[yoshyv]

#429

Axel is having trouble with CJK characters in content-disposition header

% curl -sIL 'https://[url_redacted]' |grep content-disposition
content-disposition: attachment; filename="[250213-1958][???]??????????????????????????????????????.m2ts"; filename*=UTF-8''%5B250213-1958%5D%5B%E3%83%86%E3%83%AC%E6%9D%B1%5D%E3%83%8A%E3%82%BC%E3%81%9D%E3%81%93%EF%BC%9F%E6%9D%BE%E8%8C%B8%E3%83%8F%E3%83%B3%E3%82%BF%E3%83%BC%E7%A5%9E%E3%83%AF%E3%82%B6%EF%BC%91%EF%BC%90%EF%BC%90%E6%9C%AC%E3%82%B2%E3%83%83%E3%83%88%EF%BC%86%E5%BE%A9%E6%B4%BB%EF%BC%81%E4%B8%96%E7%95%8C%E3%83%8A%E3%82%BC%E3%81%9D%E3%81%93%E3%81%AB%EF%BC%9F%E6%97%A5%E6%9C%AC%E4%BA%BA%EF%BC%B3%EF%BC%B0.m2ts

Actual downloaded filename "[250213-1958][]___________________________________.m2ts"

OS: Debian sid
Axel built from latest git (commit b1b8c2f)

% ./axel -V
Axel 2.17.14 (linux-gnu)

Copyright 2001-2007 Wilmer van der Gaast,
          2007-2009 Giridhar Appaji Nag,
          2008-2010 Philipp Hagemeister,
          2015-2017 Joao Eriberto Mota Filho,
          2016-2017 Stephen Thirlwall,
          2017      Antonio Quartulli,
          2017-2024 Ismael Luceno,
                    and others.
Please, see the CREDITS file.

[Ghoulayush]

Hi , I'd like to take on this issue.
It looks like Axel only uses the filename= parameter in Content-Disposition, but ignores the RFC 6266 filename*= form that supports UTF-8 and percent-encoding.
The fix would be to :

1. Read the value from filename*= when present,
2. Percent-decode it into UTF-8, and
3. Prefer it over the legacy filename=.

This should fix problems with CJK and other non-ASCII filenames. Could you assign me this issue ?

[ismaell]

Done.

[Ghoulayush]

Thanks for assigning this issue to me! I’ll start working on this and open a PR once it’s ready.