Refactor error messages for clarity and consistency in registry handling

Author: janosmurai

dem/__main__.py

@@ -33,7 +33,7 @@ def main() -> None:
     except LookupError as e:
         stderr.print("[red]" + str(e) + "[/]")
     except RegistryError as e:
-        stderr.print("[red]" + str(e) + "\nUsing local tool images only![/]")
+        stderr.print(f"[red]{str(e)}[/]")
     except docker.errors.DockerException as e:
         stderr.print("[red]" + str(e) + "[/]")
 

dem/core/registry.py

@@ -137,7 +137,7 @@ def __init__(self, registry_config: dict) -> None:
         super().__init__(registry_config)
 
         if not self._namespace:
-            raise RegistryError("Invalid registry configuration. For Docker Hub the namesapce must be set.")
+            raise RegistryError("Invalid registry configuration. For Docker Hub the namespace must be set.")
 
     def _append_repo_with_tag(self, endpoint_response: dict, repo: str) -> None:
         """ Get the tags from the endpoint response. Save the tags alongside with the actual repo

tests/core/test_registry.py

@@ -366,9 +366,12 @@ def test_DockerHub_invalid_registry_config() -> None:
     }
 
     # Run unit under test
-    with pytest.raises(registry.RegistryError):
+    with pytest.raises(registry.RegistryError) as exported_exception_info:
         registry.DockerHub(test_registry_config)
 
+    # Check expectations
+    assert "Registry error: Invalid registry configuration. For Docker Hub the namespace must be set." == str(exported_exception_info.value)
+
 @patch.object(registry.DockerHub, "__init__")
 def test_DockerHub__append_repo_with_tag(mock___init__: MagicMock) -> None:
     # Test setup

tests/test__main__.py

@@ -92,7 +92,7 @@ def test_cli_RegistryError(mock_Platform: MagicMock, mock_cli_main: MagicMock, m
     mock_Core.set_user_output.assert_called_once_with(mock_tui_user_output)
     mock_platform.config_file.update.assert_called_once()
     mock_cli_main.typer_cli.assert_called_once_with(prog_name=__command__)
-    mock_stderr_print.assert_called_once_with("[red]Registry error: " + test_exception_text + "\nUsing local tool images only![/]")
+    mock_stderr_print.assert_called_once_with(f"[red]Registry error: {test_exception_text}[/]")
 
 @patch("dem.__main__.stdout.print")
 @patch("dem.__main__.stderr.print")