Skip to content

Commit 6fb5ea5

Browse files
committed
add h265 support to the segment builder classes
1 parent 93b9d2b commit 6fb5ea5

File tree

6 files changed

+540
-218
lines changed

6 files changed

+540
-218
lines changed

Source/C++/Apps/Mp42Hls/Mp42Hls.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -562,7 +562,7 @@ SampleEncrypter::EncryptVideoSample(AP4_DataBuffer& sample, AP4_UI08 nalu_length
562562
PreventStartCodeEmulation(nalu+nalu_length_size, nalu_length, escaped_nalu);
563563

564564
// the size may have changed
565-
// FIXME: this could overflow if nalu_length_size is too small
565+
// TODO: this could overflow if nalu_length_size is too small
566566
switch (nalu_length_size) {
567567
case 1:
568568
nalu[0] = (AP4_UI08)(escaped_nalu.GetDataSize()&0xFF);

Source/C++/Apps/Mp4Mux/Mp4Mux.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
|
33
| AP4 - Elementary Stream Muliplexer
44
|
5-
| Copyright 2002-2016 Axiomatic Systems, LLC
5+
| Copyright 2002-2019 Axiomatic Systems, LLC
66
|
77
|
88
| This file is part of Bento4/AP4 (MP4 Atom Processing Library).
@@ -39,9 +39,9 @@
3939
/*----------------------------------------------------------------------
4040
| constants
4141
+---------------------------------------------------------------------*/
42-
#define BANNER "MP4 Elementary Stream Multiplexer - Version 1.1\n"\
42+
#define BANNER "MP4 Elementary Stream Multiplexer - Version 2.0\n"\
4343
"(Bento4 Version " AP4_VERSION_STRING ")\n"\
44-
"(c) 2002-20016 Axiomatic Systems, LLC"
44+
"(c) 2002-20019 Axiomatic Systems, LLC"
4545

4646
const unsigned int AP4_MUX_DEFAULT_VIDEO_FRAME_RATE = 24;
4747
const unsigned int AP4_MUX_READ_BUFFER_SIZE = 65536;
@@ -717,8 +717,8 @@ AddH265Track(AP4_Movie& movie,
717717
AP4_UI32 min_spatial_segmentation = 0; // TBD (should read from VUI if present)
718718
AP4_UI08 parallelism_type = 0; // unknown
719719
AP4_UI08 chroma_format = sps->chroma_format_idc;
720-
AP4_UI08 luma_bit_depth = 8; // FIXME: hardcoded temporarily, should be read from the bitstream
721-
AP4_UI08 chroma_bit_depth = 8; // FIXME: hardcoded temporarily, should be read from the bitstream
720+
AP4_UI08 luma_bit_depth = 8; // hardcoded temporarily, should be read from the bitstream
721+
AP4_UI08 chroma_bit_depth = 8; // hardcoded temporarily, should be read from the bitstream
722722
AP4_UI16 average_frame_rate = 0; // unknown
723723
AP4_UI08 constant_frame_rate = 0; // unknown
724724
AP4_UI08 num_temporal_layers = 0; // unknown

Source/C++/Core/Ap4FileWriter.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ AP4_FileWriter::Write(AP4_File& file, AP4_ByteStream& stream, Interleaving /* in
117117
movie->GetMoovAtom()->Write(stream);
118118

119119
// create and write the media data (mdat)
120-
// FIXME: this only supports 32-bit mdat size
120+
// TODO: this only supports 32-bit mdat size
121121
stream.WriteUI32((AP4_UI32)mdat_size);
122122
stream.WriteUI32(AP4_ATOM_TYPE_MDAT);
123123

0 commit comments

Comments
 (0)