Mark StringUtils::format deprecated, use fmt::format instead (#2029)

Author: halx99

CHANGELOG.md

@@ -20,6 +20,7 @@
   - Rename all AXLOG/printf to AXLOGD (without .\core, .\3rdparty) by @aismann in https://github.com/axmolengine/axmol/pull/2020
   - Set several log messages to verbose level by @rh101 in https://github.com/axmolengine/axmol/pull/2021
   - Change AXLOGI to more appropriate AXLOGD for several log calls by @rh101 in https://github.com/axmolengine/axmol/pull/2028
+- `StringUtils::format`, use `fmt::format` instead.
 
 ### Bug Fixes
 

core/2d/Action.cpp

@@ -47,7 +47,7 @@ Action::~Action()
 
 std::string Action::description() const
 {
-    return StringUtils::format("<Action | Tag = %d", _tag);
+    return fmt::format("<Action | Tag = {}", _tag);
 }
 
 void Action::startWithTarget(Node* aTarget)

core/2d/FastTMXLayer.cpp

@@ -962,7 +962,7 @@ void FastTMXLayer::setupTileSprite(Sprite* sprite, const Vec2& pos, uint32_t gid
 
 std::string FastTMXLayer::getDescription() const
 {
-    return StringUtils::format("<FastTMXLayer | tag = %d, size = %d,%d>", _tag, (int)_mapTileSize.width,
+    return fmt::format("<FastTMXLayer | tag = {}, size = {},{}>", _tag, (int)_mapTileSize.width,
                                (int)_mapTileSize.height);
 }
 

core/2d/FastTMXTiledMap.cpp

@@ -260,7 +260,7 @@ Value FastTMXTiledMap::getPropertiesForGID(int GID) const
 
 std::string FastTMXTiledMap::getDescription() const
 {
-    return StringUtils::format("<FastTMXTiledMap | Tag = %d, Layers = %d", _tag, static_cast<int>(_children.size()));
+    return fmt::format("<FastTMXTiledMap | Tag = {}, Layers = {}", _tag, static_cast<int>(_children.size()));
 }
 
 void FastTMXTiledMap::setTileAnimEnabled(bool enabled)

core/2d/FontFNT.cpp

@@ -126,9 +126,9 @@ BMFontConfiguration::~BMFontConfiguration()
 
 std::string BMFontConfiguration::description() const
 {
-    return StringUtils::format(
-        "<BMFontConfiguration = " AX_FORMAT_PRINTF_SIZE_T " | Glphys:%d Kernings:%d | Image = %s>", (size_t)this,
-        static_cast<int>(_fontDefDictionary.size()), static_cast<int>(_kerningDictionary.size()), _atlasName.c_str());
+    return fmt::format(
+        "<BMFontConfiguration = " AX_FORMAT_PRINTF_SIZE_T " | Glphys:{} Kernings:{} | Image = {}>", (size_t)this,
+        static_cast<int>(_fontDefDictionary.size()), static_cast<int>(_kerningDictionary.size()), _atlasName);
 }
 
 void BMFontConfiguration::purgeKerningDictionary()

core/2d/LabelAtlas.cpp

@@ -283,7 +283,7 @@ void LabelAtlas::draw(Renderer* renderer, const Mat4& transform, uint32_t flags)
 
 std::string LabelAtlas::getDescription() const
 {
-    return StringUtils::format("<LabelAtlas | Tag = %d, Label = '%s'>", _tag, _string.c_str());
+    return fmt::format("<LabelAtlas | Tag = {}, Label = '{}'>", _tag, _string);
 }
 
 NS_AX_END

core/2d/Layer.cpp

@@ -336,7 +336,7 @@ void LayerGradient::setCompressedInterpolation(bool compress)
 
 std::string LayerGradient::getDescription() const
 {
-    return StringUtils::format("<LayerGradient | Tag = %d>", _tag);
+    return fmt::format("<LayerGradient | Tag = {}>", _tag);
 }
 
 /**
@@ -750,7 +750,7 @@ void LayerMultiplex::switchToAndReleaseMe(int n)
 
 std::string LayerMultiplex::getDescription() const
 {
-    return StringUtils::format("<LayerMultiplex | Tag = %d, Layers = %d", _tag, static_cast<int>(_children.size()));
+    return fmt::format("<LayerMultiplex | Tag = {}, Layers = {}", _tag, static_cast<int>(_children.size()));
 }
 
 NS_AX_END

core/2d/Menu.cpp

@@ -555,7 +555,7 @@ bool Menu::isOpacityModifyRGB() const
 
 std::string Menu::getDescription() const
 {
-    return StringUtils::format("<Menu | Tag = %d>", _tag);
+    return fmt::format("<Menu | Tag = {}>", _tag);
 }
 
 NS_AX_END

core/2d/MenuItem.cpp

@@ -125,7 +125,7 @@ void MenuItem::setCallback(const ccMenuCallback& callback)
 
 std::string MenuItem::getDescription() const
 {
-    return StringUtils::format("<MenuItem | tag = %d>", _tag);
+    return fmt::format("<MenuItem | tag = {}>", _tag);
 }
 
 //

core/2d/Node.cpp

@@ -240,7 +240,7 @@ void Node::cleanup()
 
 std::string Node::getDescription() const
 {
-    return StringUtils::format("<Node | Tag = %d", _tag);
+    return fmt::format("<Node | Tag = {}", _tag);
 }
 
 // MARK: getters / setters