Fix BUILD_SHARED_LIBS for Android (#2462)

Author: IamSanjid

3rdparty/glad/CMakeLists.txt

@@ -13,6 +13,9 @@ if(BUILD_SHARED_LIBS)
     PUBLIC GLAD_API_CALL_EXPORT=1
     PRIVATE GLAD_API_CALL_EXPORT_BUILD=1
   )
+  if (NOT WINDOWS AND AX_USE_GL)
+    target_link_libraries(${target_name} EGL)
+  endif()
 endif()
 
 if(ANDROID)

3rdparty/lua/plainlua/CMakeLists.txt

@@ -20,7 +20,12 @@ if(WIN32)
     #     target_link_libraries(${target_name} PRIVATE runtimeobject)
     # endif()
 else()
-    add_library(${target_name} ${LUA_CORE})
+    if (BUILD_SHARED_LIBS AND NOT WINRT)
+        set(LUA_BUILD_AS_DLL FALSE)
+        add_library(${target_name} SHARED ${LUA_CORE} ${LUA_SRC_PATH}/plainlua.def)
+    else()
+        add_library(${target_name} ${LUA_CORE})
+    endif()
 endif()
 
 target_compile_definitions(${target_name} 

core/CMakeLists.txt

@@ -456,6 +456,18 @@ endif()
 
 if(ANDROID)
     add_subdirectory(${_AX_ROOT}/core/platform/android ${ENGINE_BINARY_PATH}/core/cpp-android)
+    if (BUILD_SHARED_LIBS)
+        # whole archive for jni
+        target_link_libraries(${_AX_CORE_LIB} -Wl,--whole-archive cpp_android_spec -Wl,--no-whole-archive)
+        if (_AX_LUA_PROJ)
+            add_subdirectory(${_AX_ROOT}/extensions/scripting/lua-bindings/proj.android ${ENGINE_BINARY_PATH}/extensions/lua-android)
+            target_link_libraries(${_AX_CORE_LIB} -Wl,--whole-archive lua_android_spec -Wl,--no-whole-archive)
+        endif()
+
+        if (_AX_LUA_PROJ OR AX_ENABLE_EXT_LUA)
+            target_link_libraries(${_AX_CORE_LIB} ${AX_LUA_ENGINE})
+        endif()
+    endif()
 endif()
 
 if(LINUX)

core/platform/android/CMakeLists.txt

@@ -18,7 +18,9 @@ add_library(${target_name} STATIC
   ${${target_name}_src}
 )
 
-target_link_libraries(${target_name} ${_AX_CORE_LIB})
+if(NOT BUILD_SHARED_LIBS)
+  target_link_libraries(${target_name} ${_AX_CORE_LIB})
+endif()
 
 target_include_directories(${target_name}
   PRIVATE ..

templates/cpp/cmake/modules/AXGameTargetSetup.cmake

@@ -2,8 +2,12 @@ if(NOT ANDROID)
     add_executable(${APP_NAME} ${APP_SOURCES})
 else()
     add_library(${APP_NAME} SHARED ${APP_SOURCES})
-    # whole archive for jni
-    target_link_libraries(${APP_NAME} -Wl,--whole-archive cpp_android_spec -Wl,--no-whole-archive)
+
+    # whole archive for jni when not building engine as shared libs, otherwise libaxmol.so is archived with it.
+    if (NOT BUILD_SHARED_LIBS)
+        target_link_libraries(${APP_NAME} -Wl,--whole-archive cpp_android_spec -Wl,--no-whole-archive)
+    endif()
+
     config_android_shared_libs("dev.axmol.lib" "${CMAKE_CURRENT_SOURCE_DIR}/proj.android/app/src")
 endif()
 

templates/lua/CMakeLists.txt

@@ -37,6 +37,9 @@ set(CMAKE_MODULE_PATH
     ${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules
 )
 
+# Important when BUILD_SHARED_LIBS option is set to TRUE
+set(_AX_LUA_PROJ TRUE)
+
 # NOTE: The order of the cmake module "include(AXGame...)" statements matters
 include(AXGameEngineSetup)
 

templates/lua/cmake/modules/AXGameTargetSetup.cmake

@@ -3,10 +3,12 @@ if(NOT ANDROID)
 else()
     add_library(${APP_NAME} SHARED ${APP_SOURCES})
 
-    # whole archive for jni
-    target_link_libraries(${APP_NAME} -Wl,--whole-archive cpp_android_spec -Wl,--no-whole-archive)
-    add_subdirectory(${_AX_ROOT}/extensions/scripting/lua-bindings/proj.android ${ENGINE_BINARY_PATH}/extensions/lua-android)
-    target_link_libraries(${APP_NAME} -Wl,--whole-archive lua_android_spec -Wl,--no-whole-archive)
+    # whole archive for jni when not building engine as shared libs, otherwise libaxmol.so is archived with it.
+    if (NOT BUILD_SHARED_LIBS)
+        target_link_libraries(${APP_NAME} -Wl,--whole-archive cpp_android_spec -Wl,--no-whole-archive)
+        add_subdirectory(${_AX_ROOT}/extensions/scripting/lua-bindings/proj.android ${ENGINE_BINARY_PATH}/extensions/lua-android)
+        target_link_libraries(${APP_NAME} -Wl,--whole-archive lua_android_spec -Wl,--no-whole-archive)
+    endif()
 
     config_android_shared_libs("dev.axmol.lib" "${CMAKE_CURRENT_SOURCE_DIR}/proj.android/app/src")
 endif()