Skip to content

Commit 63c0dcb

Browse files
committed
Improve 1kiss version match rules
1 parent a7b345b commit 63c0dcb

File tree

2 files changed

+17
-15
lines changed

2 files changed

+17
-15
lines changed

1k/1kiss.ps1

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -567,29 +567,31 @@ function find_prog($name, $path = $null, $mode = 'ONLY', $cmd = $null, $params =
567567

568568
# try get match expr and preferred ver
569569
$checkVerCond = $null
570-
$requiredMin = ''
570+
$minimalVer = ''
571571
$preferredVer = ''
572572
$requiredVer = $manifest[$name]
573573
if ($requiredVer) {
574574
$preferredVer = $null
575-
if ($requiredVer.EndsWith('+')) {
576-
$preferredVer = $requiredVer.TrimEnd('+')
577-
$checkVerCond = '$(version_ge $foundVer $preferredVer)'
578-
}
579-
elseif ($requiredVer -eq '*') {
575+
if ($requiredVer -eq '*') {
580576
$checkVerCond = '$True'
581577
$preferredVer = 'latest'
582578
}
583579
else {
584580
$verArr = $requiredVer.Split('~')
585581
$isRange = $verArr.Count -gt 1
582+
$minimalVer = $verArr[0]
586583
$preferredVer = $verArr[$isRange]
587-
if ($isRange -gt 1) {
588-
$requiredMin = $verArr[0]
589-
$checkVerCond = '$(version_in_range $foundVer $requiredMin $preferredVer)'
590-
}
591-
else {
592-
$checkVerCond = '$(version_eq $foundVer $preferredVer)'
584+
if ($preferredVer.EndsWith('+')) {
585+
$preferredVer = $preferredVer.TrimEnd('+')
586+
if ($minimalVer.EndsWith('+')) { $minimalVer = $minimalVer.TrimEnd('+') }
587+
$checkVerCond = '$(version_ge $foundVer $minimalVer)'
588+
} else {
589+
if ($isRange) {
590+
$checkVerCond = '$(version_in_range $foundVer $minimalVer $preferredVer)'
591+
}
592+
else {
593+
$checkVerCond = '$(version_eq $foundVer $preferredVer)'
594+
}
593595
}
594596
}
595597
if (!$checkVerCond) {
@@ -623,7 +625,7 @@ function find_prog($name, $path = $null, $mode = 'ONLY', $cmd = $null, $params =
623625
else {
624626
$foundVer = "$($cmd_info.Version)"
625627
}
626-
[void]$requiredMin
628+
[void]$minimalVer
627629
if ($checkVerCond) {
628630
$matched = Invoke-Expression $checkVerCond
629631
if ($matched) {

1k/manifest.ps1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@
1111
if ($Global:is_axmol_app -or $Global:is_axmol_engine) {
1212
$manifest['nuget'] = '5.5.1' # since 5.6.0, requires .net 4.0
1313
$manifest['glslcc'] = '1.9.5+'
14-
$manifest['cmake'] = '3.29.3+'
14+
$manifest['cmake'] = '3.29.3~3.30.1+'
1515
$manifest['emsdk'] = '3.1.63+'
16-
$manifest['jdk'] = '17.0.10+'
16+
$manifest['jdk'] = '17.0.10~17.0.11+'
1717
}
1818

1919
# android sdk tools

0 commit comments

Comments
 (0)