Merge pull request #601 from alltilla/fix-metrics-labels-crash

MrAnno · web-flow · commit 743fc9603ddb · 2025-04-24T14:05:50.000+02:00
filterx: fix `metrics_labels` crash
diff --git a/lib/filterx/object-metrics-labels.c b/lib/filterx/object-metrics-labels.c
@@ -85,6 +85,9 @@ _get_subscript(FilterXDict *s, FilterXObject *key)
   if (!filterx_object_extract_string_ref(key, &key_str, NULL))
     return NULL;
 
+  if (!self->labels->len)
+    return NULL;
+
   for (guint i = self->labels->len - 1; i >= 0; i--)
     {
       StatsClusterLabel *label = &g_array_index(self->labels, StatsClusterLabel, i);
diff --git a/news/fx-bugfix-601.md b/news/fx-bugfix-601.md
@@ -0,0 +1 @@
+`metrics_labels`: Fixed a crash that occurred when trying to get a label from an empty object.

Original file line number	Diff line number	Diff line change
`@@ -85,6 +85,9 @@ _get_subscript(FilterXDict s, FilterXObject key)`
`85`	`85`	`if (!filterx_object_extract_string_ref(key, &key_str, NULL))`
`86`	`86`	`return NULL;`
`87`	`87`
	`88`	`+ if (!self->labels->len)`
	`89`	`+ return NULL;`
	`90`	`+`
`88`	`91`	`for (guint i = self->labels->len - 1; i >= 0; i--)`
`89`	`92`	`{`
`90`	`93`	`StatsClusterLabel *label = &g_array_index(self->labels, StatsClusterLabel, i);`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+`metrics_labels`: Fixed a crash that occurred when trying to get a label from an empty object.