enable clippy::cast_possible_{truncation,wrap}

Author: tamird

Cargo.toml

@@ -92,8 +92,8 @@ all = "warn"
 as_ptr_cast_mut = "warn"
 as_underscore = "warn"
 cast_lossless = "warn"
-#cast_possible_truncation = "warn"
-#cast_possible_wrap = "warn"
+cast_possible_truncation = "warn"
+cast_possible_wrap = "warn"
 cast_precision_loss = "warn"
 cast_sign_loss = "warn"
 char_lit_as_u8 = "warn"

src/llvm/di.rs

@@ -238,7 +238,7 @@ impl<'ctx> DISanitizer<'ctx> {
                 self.visit_item(Item::Operand(Operand {
                     parent: value_ref,
                     value: operand,
-                    index: index as u32,
+                    index: index.try_into().unwrap(),
                 }))
             }
         }
@@ -411,12 +411,17 @@ struct Operand {
 
 impl Operand {
     fn replace(&mut self, value: LLVMValueRef) {
+        let Self {
+            parent,
+            value: _,
+            index,
+        } = self;
         unsafe {
-            if !LLVMIsAMDNode(self.parent).is_null() {
+            if !LLVMIsAMDNode(*parent).is_null() {
                 let value = LLVMValueAsMetadata(value);
-                LLVMReplaceMDNodeOperandWith(self.parent, self.index, value);
-            } else if !LLVMIsAUser(self.parent).is_null() {
-                LLVMSetOperand(self.parent, self.index, value);
+                LLVMReplaceMDNodeOperandWith(*parent, *index, value);
+            } else if !LLVMIsAUser(*parent).is_null() {
+                LLVMSetOperand(*parent, *index, value);
             }
         }
     }

src/llvm/mod.rs

@@ -62,7 +62,13 @@ pub(crate) fn init(args: &[Cow<'_, CStr>], overview: &CStr) {
     }
 
     let c_ptrs = args.iter().map(|s| s.as_ptr()).collect::<Vec<_>>();
-    unsafe { LLVMParseCommandLineOptions(c_ptrs.len() as i32, c_ptrs.as_ptr(), overview.as_ptr()) };
+    unsafe {
+        LLVMParseCommandLineOptions(
+            c_ptrs.len().try_into().unwrap(),
+            c_ptrs.as_ptr(),
+            overview.as_ptr(),
+        )
+    };
 }
 
 pub(crate) fn find_embedded_bitcode(
@@ -93,7 +99,7 @@ pub(crate) fn find_embedded_bitcode(
             let name = unsafe { CStr::from_ptr(name) };
             if name == c".llvmbc" {
                 let buf = unsafe { LLVMGetSectionContents(iter) };
-                let size = unsafe { LLVMGetSectionSize(iter) } as usize;
+                let size = unsafe { LLVMGetSectionSize(iter) }.try_into().unwrap();
                 ret = Some(unsafe { slice::from_raw_parts(buf.cast(), size).to_vec() });
                 break;
             }

src/llvm/types/di.rs

@@ -135,8 +135,8 @@ impl DIType<'_> {
 
     /// Returns the offset of the type in bits. This offset is used in case the
     /// type is a member of a composite type.
-    pub(crate) fn offset_in_bits(&self) -> usize {
-        unsafe { LLVMDITypeGetOffsetInBits(self.metadata_ref) as usize }
+    pub(crate) fn offset_in_bits(&self) -> u64 {
+        unsafe { LLVMDITypeGetOffsetInBits(self.metadata_ref) }
     }
 }
 

src/llvm/types/ir.rs

@@ -253,7 +253,7 @@ impl MDNode<'_> {
 
 pub(crate) struct MetadataEntries {
     entries: *mut LLVMValueMetadataEntry,
-    count: usize,
+    count: u32,
 }
 
 impl MetadataEntries {
@@ -268,14 +268,18 @@ impl MetadataEntries {
             return None;
         }
 
-        Some(Self { entries, count })
+        Some(Self {
+            entries,
+            count: count.try_into().unwrap(),
+        })
     }
 
     pub(crate) fn iter(&self) -> impl Iterator<Item = (LLVMMetadataRef, u32)> + '_ {
-        (0..self.count).map(move |index| unsafe {
+        let Self { entries, count } = self;
+        (0..*count).map(|index| unsafe {
             (
-                LLVMValueMetadataEntriesGetMetadata(self.entries, index as u32),
-                LLVMValueMetadataEntriesGetKind(self.entries, index as u32),
+                LLVMValueMetadataEntriesGetMetadata(*entries, index),
+                LLVMValueMetadataEntriesGetKind(*entries, index),
             )
         })
     }