Added goto cleanup and fixed some issues

Author: lowlevel01

al-khaser/AntiVM/Generic.cpp

@@ -2102,66 +2102,53 @@ Check if machine is hosted on Cloud.
 BOOL hosting_check()
 {
 	TCHAR msg[256] = _T("Checking if Machine is hosted on Cloud");
-
 	WSADATA wsaData;
+	SOCKET sock = INVALID_SOCKET;
+	addrinfo* result = nullptr;
+	addrinfo hints;
+	BOOL retVal = FALSE;
+	std::string request;
+	std::string response;
+	const int bufferSize = 512;
+	char buffer[bufferSize];
+	int bytesReceived = 0;
+
 	if (WSAStartup(MAKEWORD(2, 2), &wsaData) != 0)
 	{
-		//print_results(FALSE, msg);
-		return -1;
+		goto cleanup;
 	}
 
-	// Create socket
-	SOCKET sock = socket(AF_INET, SOCK_STREAM, IPPROTO_TCP);
+	sock = socket(AF_INET, SOCK_STREAM, IPPROTO_TCP);
 	if (sock == INVALID_SOCKET)
 	{
-		WSACleanup();
-		//print_results(FALSE, msg);
-		return -1;
+		goto cleanup;
 	}
 
-	addrinfo* result = nullptr;
-	addrinfo hints = {};
+
+	memset(&hints, 0, sizeof(hints));
 	hints.ai_family = AF_INET;
 	hints.ai_socktype = SOCK_STREAM;
 	hints.ai_protocol = IPPROTO_TCP;
 
 	if (getaddrinfo("ip-api.com", "80", &hints, &result) != 0)
 	{
-		closesocket(sock);
-		WSACleanup();
-		//print_results(FALSE, msg);
-		return -1;
+		goto cleanup;
 	}
 
 	if (connect(sock, result->ai_addr, static_cast<int>(result->ai_addrlen)) == SOCKET_ERROR)
 	{
-		freeaddrinfo(result);
-		closesocket(sock);
-		WSACleanup();
-		//print_results(FALSE, msg);
-		return -1;
+		goto cleanup;
 	}
 
-	freeaddrinfo(result);
-
-	std::string request = "GET /json/?fields=hosting HTTP/1.1\r\n";
+	request = "GET /json/?fields=hosting HTTP/1.1\r\n";
 	request += "Host: ip-api.com\r\n";
 	request += "Connection: close\r\n\r\n";
 
 	if (send(sock, request.c_str(), static_cast<int>(request.length()), 0) == SOCKET_ERROR)
 	{
-		closesocket(sock);
-		WSACleanup();
-		//print_results(FALSE, msg);
-		return -1;
+		goto cleanup;
 	}
 
-	// Receive response
-	const int bufferSize = 512;
-	char buffer[bufferSize];
-	int bytesReceived;
-	std::string response;
-
 	do
 	{
 		bytesReceived = recv(sock, buffer, bufferSize - 1, 0);
@@ -2174,26 +2161,18 @@ BOOL hosting_check()
 
 	if (bytesReceived == SOCKET_ERROR)
 	{
-		closesocket(sock);
-		WSACleanup();
-		//print_results(FALSE, msg);
-		return -1;
+		goto cleanup;
 	}
 
-	// Check if the response indicates hosting
 	if (response.find("\"hosting\":true") != std::string::npos)
 	{
-		//print_results(TRUE, msg);
-		closesocket(sock);
-		WSACleanup();
-		return TRUE;
-	}
-	else
-	{
-		closesocket(sock);
-		WSACleanup();
-		return FALSE;
+		retVal = TRUE;
 	}
 
+cleanup:
+	if (result) freeaddrinfo(result);
+	if (sock != INVALID_SOCKET) closesocket(sock);
+	WSACleanup();
+	return retVal;
+}
 
-}