psx/gpu: Extend TexPage to support bit depths other than 4 #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayrtonm
reviewed
Nov 30, 2025
|
|
||
| /// Texture Blend mode. | ||
| #[derive(Clone, Copy, PartialEq, Eq, Debug)] | ||
| pub enum Blend { |
Owner
There was a problem hiding this comment.
Not sure how you eventually plan to use this, but my guess is that it would be useful to make this repr(u8) or something and explicitly define the first discriminant like this
#[repr(u8)]
pub enum Blend {
Mix = 0,
Add,
Sub,
Inc,
}
That way you can do conversions to the repr type more easily like this
let x = Blend::Add;
let y: u8 = x as u8;
ayrtonm
reviewed
Nov 30, 2025
| /// bits `0` to `3`: texture page X base | ||
| /// bit `4`: texture page Y base | ||
| /// bits `5` to `6`: semi-transparency (0=B/2+F/2, 1=B+F, 2=B-F, 3=B+F/4) | ||
| /// bits `7` to `8`: Bpp |
Owner
There was a problem hiding this comment.
Is bit 8 in the texpage field or _pad? At a glance it looks like a typo to me.
Owner
|
I remember when I added |
ayrtonm
reviewed
Nov 30, 2025
| /// bit `4`: texture page Y base | ||
| pub type TexPage = PackedVertex<2, 4, 1>; | ||
| #[repr(C)] | ||
| #[derive(Clone, Copy, PartialEq, Eq, Debug)] |
Owner
There was a problem hiding this comment.
nit: Would derive(Default) be useful? (and a valid value?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.