feat(sort-imports)!: drop deprecated selectors

Author: hugop95

rules/sort-imports.ts

@@ -45,7 +45,6 @@ import { singleCustomGroupJsonSchema } from './sort-imports/types'
 import { sortNodesByGroups } from '../utils/sort-nodes-by-groups'
 import { allModifiers, allSelectors } from './sort-imports/types'
 import { createEslintRule } from '../utils/create-eslint-rule'
-import { allDeprecatedSelectors } from './sort-imports/types'
 import { reportAllErrors } from '../utils/report-all-errors'
 import { shouldPartition } from '../utils/should-partition'
 import { computeGroup } from '../utils/compute-group'
@@ -105,7 +104,7 @@ export default createEslintRule<Options, MessageId>({
     )
 
     validateGeneratedGroupsConfiguration({
-      selectors: [...allSelectors, ...allDeprecatedSelectors],
+      selectors: allSelectors,
       modifiers: allModifiers,
       options,
     })
@@ -160,14 +159,6 @@ export default createEslintRule<Options, MessageId>({
       let group: Group | null = null
 
       if (node.type !== 'VariableDeclaration' && node.importKind === 'type') {
-        if (node.type === 'ImportDeclaration') {
-          for (let selector of commonSelectors) {
-            if (selector !== 'subpath' && selector !== 'tsconfig-path') {
-              selectors.push(`${selector}-type`)
-            }
-          }
-        }
-
         selectors.push('type')
         modifiers.push('type')
       }

rules/sort-imports/types.ts

@@ -140,32 +140,6 @@ export type Options = Partial<{
   alphabet: string
 }>[]
 
-/**
- * Union type of all available import selectors. Used to categorize different
- * types of import statements.
- */
-export type Selector =
-  | SideEffectStyleSelector
-  | InternalTypeSelector
-  | ExternalTypeSelector
-  | TsconfigPathSelector
-  | SiblingTypeSelector
-  | BuiltinTypeSelector
-  | SideEffectSelector
-  | ParentTypeSelector
-  | IndexTypeSelector
-  | ExternalSelector
-  | InternalSelector
-  | BuiltinSelector
-  | SiblingSelector
-  | SubpathSelector
-  | ImportSelector
-  | ObjectSelector
-  | ParentSelector
-  | IndexSelector
-  | StyleSelector
-  | TypeSelector
-
 /**
  * Defines a custom group for import categorization.
  *
@@ -193,6 +167,25 @@ export type SingleCustomGroup = {
   elementNamePattern?: RegexOption
 }
 
+/**
+ * Union type of all available import selectors. Used to categorize different
+ * types of import statements.
+ */
+export type Selector =
+  | SideEffectStyleSelector
+  | TsconfigPathSelector
+  | SideEffectSelector
+  | ExternalSelector
+  | InternalSelector
+  | BuiltinSelector
+  | SiblingSelector
+  | SubpathSelector
+  | ImportSelector
+  | ParentSelector
+  | IndexSelector
+  | StyleSelector
+  | TypeSelector
+
 /**
  * Represents a sorting node for an import statement. Extends the base sorting
  * node with dependency information and ignore flag.
@@ -236,12 +229,6 @@ type TypeGroup = JoinWithDash<[TypeModifier, Selector]>
 /** Selector for side-effect imports that are style files (CSS, SCSS, etc.). */
 type SideEffectStyleSelector = 'side-effect-style'
 
-/** @deprecated Since v4.12.0. Will be removed in v5.0.0. */
-type InternalTypeSelector = 'internal-type'
-
-/** @deprecated Since v4.12.0. Will be removed in v5.0.0. */
-type ExternalTypeSelector = 'external-type'
-
 /** Selector for imports using TypeScript path aliases defined in tsconfig.json. */
 type TsconfigPathSelector = 'tsconfig-path'
 
@@ -251,27 +238,15 @@ type TsconfigPathSelector = 'tsconfig-path'
  */
 type ValueGroup = JoinWithDash<[Selector]>
 
-/** @deprecated Since v4.12.0. Will be removed in v5.0.0. */
-type SiblingTypeSelector = 'sibling-type'
-
-/** @deprecated Since v4.12.0. Will be removed in v5.0.0. */
-type BuiltinTypeSelector = 'builtin-type'
-
 /** Selector for side-effect imports (imports without bindings). */
 type SideEffectSelector = 'side-effect'
 
-/** @deprecated Since v4.12.0. Will be removed in v5.0.0. */
-type ParentTypeSelector = 'parent-type'
-
 /** Modifier for side-effect imports. */
 type SideEffectModifier = 'side-effect'
 
 /** Modifier for single-line imports. */
 type SinglelineModifier = 'singleline'
 
-/** @deprecated Since v4.12.0. Will be removed in v5.0.0. */
-type IndexTypeSelector = 'index-type'
-
 /** Modifier for multiline imports. */
 type MultilineModifier = 'multiline'
 
@@ -308,9 +283,6 @@ type RequireModifier = 'require'
 /** Selector for parent module imports (from parent directories). */
 type ParentSelector = 'parent'
 
-/** @deprecated This selector is never matched. Will be removed in v5.0.0. */
-type ObjectSelector = 'object'
-
 /** Base selector for all import statements. */
 type ImportSelector = 'import'
 
@@ -352,22 +324,6 @@ export let allSelectors: Selector[] = [
   'type',
 ]
 
-/**
- * List of deprecated import selectors. Maintained for backward compatibility
- * but should not be used in new configurations.
- *
- * Will be removed in v5.0.0.
- */
-export let allDeprecatedSelectors: Selector[] = [
-  'internal-type',
-  'external-type',
-  'sibling-type',
-  'builtin-type',
-  'parent-type',
-  'index-type',
-  'object',
-]
-
 /**
  * Complete list of available import modifiers. Used for validation and JSON
  * schema generation.

rules/sort-object-types/types.ts

@@ -57,10 +57,7 @@ export type Options = Partial<
       hasNumericKeysOnly?: boolean
     }
 
-    /**
-     * Custom groups for organizing object type members. Can be a structured
-     * configuration or the deprecated format.
-     */
+    /** Custom groups for organizing object type members. */
     customGroups: CustomGroupsOption<
       SingleCustomGroup,
       {