fix: require sorting type in fallback sort schema

Author: hugop95

test/utils/common-json-schemas.test.ts

@@ -96,20 +96,22 @@ describe('common-json-schemas', () => {
           ).toBeTruthy()
         })
 
-        it('should not allow invalid values', () => {
+        it('should not allow undefined type', () => {
           expect(
             commonJsonSchemaValidator({
               fallbackSort: {
-                type: 'invalid',
+                order: 'asc',
               },
             }),
           ).toBeFalsy()
         })
 
-        it('should not allow the empty object', () => {
+        it('should not allow invalid values', () => {
           expect(
             commonJsonSchemaValidator({
-              fallbackSort: {},
+              fallbackSort: {
+                type: 'invalid',
+              },
             }),
           ).toBeFalsy()
         })
@@ -120,6 +122,7 @@ describe('common-json-schemas', () => {
           expect(
             commonJsonSchemaValidator({
               fallbackSort: {
+                type: 'alphabetical',
                 order,
               },
             }),
@@ -130,6 +133,7 @@ describe('common-json-schemas', () => {
           expect(
             commonJsonSchemaValidator({
               fallbackSort: {
+                type: 'alphabetical',
                 order: 'invalid',
               },
             }),
@@ -142,6 +146,7 @@ describe('common-json-schemas', () => {
           commonJsonSchemaValidator({
             fallbackSort: {
               somethingElse: 'something',
+              type: 'alphabetical',
             },
           }),
         ).toBeFalsy()

utils/common-json-schemas.ts

@@ -124,7 +124,7 @@ function buildFallbackSortJsonSchema({
     },
     description: 'Fallback sort order.',
     additionalProperties: false,
-    minProperties: 1,
+    required: ['type'],
     type: 'object',
   }
 }