address review

Author: yariks5s

docs/en/sql-reference/data-types/time.md

@@ -6,12 +6,12 @@ sidebar_label: Time
 
 # Time
 
-The `Time` data type is used to store a time-of-day value independent of any calendar date. It is ideal for representing daily schedules, event times, or any situation where only the time component (hours, minutes, seconds, and optionally fractions of a second) is important.
+The `Time` data type is used to store a time value independent of any calendar date. It is ideal for representing daily schedules, event times, or any situation where only the time component (hours, minutes, seconds) is important.
 
 Syntax:
 
 ``` sql
-Time([timezone])
+Time()
 ```
 
 Supported range of values: \[-999:59:59, 999:59:59\].

docs/en/sql-reference/data-types/time64.md

@@ -6,20 +6,20 @@ sidebar_label: Time64
 
 # Time64
 
-The Time64 data type allows storing time-of-day values with sub-second precision. Unlike DateTime64, it does not include a calendar date, but only represents time within a single day. The precision defines the resolution of stored values in fractional seconds.
+The Time64 data type allows storing time values with sub-second precision. Unlike DateTime64, it does not include a calendar date, but only represents time. The precision defines the resolution of stored values in fractional seconds.
 
 Tick size (precision): 10<sup>-precision</sup> seconds. Valid range: [ 0 : 9 ].
 Typically, are used - 3 (milliseconds), 6 (microseconds), 9 (nanoseconds).
 
 **Syntax:**
 
 ``` sql
-Time64(precision, [timezone])
+Time64(precision)
 ```
 
 Internally, Time64 stores data as an Int64 number of ticks since the start of the day (000:00:00.000000000). The tick resolution is determined by the precision parameter. Optionally, a time zone can be specified at the column level, which affects how time values are interpreted and displayed in text format.
 
-Unlike DateTime64, Time64 does not store a date component, meaning that it only represents a time within a 24-hour cycle. See details in [Time](../../sql-reference/data-types/time.md).
+Unlike DateTime64, Time64 does not store a date component, meaning that it only represents time. See details in [Time](../../sql-reference/data-types/time.md).
 
 Supported range of values: \[000:00:00, 999:59:59.99999999\]
 

src/Common/DateLUTImpl.h

@@ -1313,6 +1313,7 @@ class DateLUTImpl
         if (unlikely(t < 0))
         {
             is_negative = true;
+            t = -t;
         }
         res.second = t % 60;
         res.minute = t / 60 % 60;

src/Common/LocalTime.h

@@ -4,6 +4,7 @@
 #include <cstring>
 #include <stdexcept>
 #include <Common/DateLUT.h>
+#include <Common/DateLUTImpl.h>
 #include <Common/LocalDate.h>
 
 /**
@@ -23,9 +24,6 @@ class LocalTime
     unsigned char m_minute;                 /// Minutes (0-59)
     unsigned char m_second;                 /// Seconds (0-59)
 
-    /// Padding to fill the structure to 8 bytes and ensure safe invocation of `memcmp`.
-    unsigned char pad[4] = {0};
-
     /**
      * Initializes time from `time_t` and time zone.
      *
@@ -44,9 +42,6 @@ class LocalTime
         m_hour = components.hour;
         m_minute = components.minute;
         m_second = components.second;
-
-        // Initialize padding
-        std::memset(pad, 0, sizeof(pad));
     }
 
     /**
@@ -133,9 +128,6 @@ class LocalTime
         }
         else
             throw std::runtime_error("Cannot parse LocalTime: " + std::string(s, length));
-
-        // Initialize padding
-        std::memset(pad, 0, sizeof(pad));
     }
 
     // Helper function to compute the total seconds represented by the LocalTime.
@@ -170,9 +162,7 @@ class LocalTime
      */
     LocalTime(bool is_negative_, uint64_t hour_, unsigned char minute_, unsigned char second_) /// NOLINT
         : is_negative(is_negative_), m_hour(hour_), m_minute(minute_), m_second(second_)
-    {
-        std::memset(pad, 0, sizeof(pad));
-    }
+    {}
 
     /**
      * Constructor from a string.
@@ -191,9 +181,7 @@ class LocalTime
      * Default constructor initializes time to 0000:00:00.
      */
     LocalTime() : m_hour(0), m_minute(0), m_second(0)
-    {
-        std::memset(pad, 0, sizeof(pad));
-    }
+    {}
 
     /**
      * Constructor from data pointer and length.

src/Core/SortCursor.h

@@ -797,6 +797,7 @@ class SortQueueVariants
         SortingQueueImpl<SpecializedSingleNullableColumnSortCursor<ColumnDecimal<Decimal128>>, strategy>,
         SortingQueueImpl<SpecializedSingleNullableColumnSortCursor<ColumnDecimal<Decimal256>>, strategy>,
         SortingQueueImpl<SpecializedSingleNullableColumnSortCursor<ColumnDecimal<DateTime64>>, strategy>,
+        SortingQueueImpl<SpecializedSingleNullableColumnSortCursor<ColumnDecimal<Time64>>, strategy>,
 
         SortingQueueImpl<SpecializedSingleNullableColumnSortCursor<ColumnVector<UUID>>, strategy>,
         SortingQueueImpl<SpecializedSingleNullableColumnSortCursor<ColumnVector<IPv4>>, strategy>,

src/IO/ReadHelpers.h

@@ -12,6 +12,7 @@
 #include <Common/StackTrace.h>
 #include <Common/formatIPv6.h>
 #include <Common/DateLUT.h>
+#include <Common/DateLUTImpl.h>
 #include <Common/LocalDate.h>
 #include <Common/LocalDateTime.h>
 #include <Common/transformEndianness.h>