Merge pull request ClickHouse#79844 from wxybear/fix_object_storage_cluster_wrong_count

fix: ObjectStorageCluster table function return wrong count() after applyTrivialCount optimized

Author: Avogar

src/Storages/ObjectStorage/StorageObjectStorageCluster.cpp

@@ -85,6 +85,18 @@ std::string StorageObjectStorageCluster::getName() const
     return configuration->getEngineName();
 }
 
+std::optional<UInt64> StorageObjectStorageCluster::totalRows(ContextPtr query_context) const
+{
+    configuration->update(object_storage, query_context);
+    return configuration->totalRows();
+}
+
+std::optional<UInt64> StorageObjectStorageCluster::totalBytes(ContextPtr query_context) const
+{
+    configuration->update(object_storage, query_context);
+    return configuration->totalBytes();
+}
+
 void StorageObjectStorageCluster::updateQueryToSendIfNeeded(
     ASTPtr & query,
     const DB::StorageSnapshotPtr & storage_snapshot,

src/Storages/ObjectStorage/StorageObjectStorageCluster.h

@@ -29,6 +29,9 @@ class StorageObjectStorageCluster : public IStorageCluster
 
     String getPathSample(StorageInMemoryMetadata metadata, ContextPtr context);
 
+    std::optional<UInt64> totalRows(ContextPtr query_context) const override;
+    std::optional<UInt64> totalBytes(ContextPtr query_context) const override;
+
 private:
     void updateQueryToSendIfNeeded(
         ASTPtr & query,

tests/integration/test_storage_iceberg/test.py

@@ -650,6 +650,8 @@ def add_df(mode):
         )
         assert len(cluster_secondary_queries) == 1
 
+    # write 3 times
+    assert int(instance.query(f"SELECT count() FROM {table_function_expr_cluster}")) == 100 * 3
 
 @pytest.mark.parametrize("format_version", ["1", "2"])
 @pytest.mark.parametrize("storage_type", ["s3", "azure", "local"])