hide credentails for datalake catalog

hanfei1991 · hanfei1991 · commit 187d4976e1b2 · 2025-05-07T16:58:06.000Z
diff --git a/src/Parsers/FunctionSecretArgumentsFinder.h b/src/Parsers/FunctionSecretArgumentsFinder.h
@@ -623,7 +623,7 @@ class FunctionSecretArgumentsFinder
             /// PostgreSQL('host:port', 'database', 'user', 'password')
             findMySQLDatabaseSecretArguments();
         }
-        else if (engine_name == "S3")
+        else if (engine_name == "S3" || engine_name == "DataLakeCatalog")
         {
             /// S3('url', 'access_key_id', 'secret_access_key')
             findS3DatabaseSecretArguments();
diff --git a/tests/integration/test_database_iceberg/test.py b/tests/integration/test_database_iceberg/test.py
@@ -138,6 +138,9 @@ def create_clickhouse_iceberg_database(
 SETTINGS {",".join((k+"="+repr(v) for k, v in settings.items()))}
     """
     )
+    show_result = node.query(f"SHOW DATABASE {name}")
+    assert minio_secret_key not in show_result
+    assert "HIDDEN" in show_result
 
 
 def print_objects():

Original file line number	Diff line number	Diff line change
`@@ -623,7 +623,7 @@ class FunctionSecretArgumentsFinder`
`623`	`623`	`/// PostgreSQL('host:port', 'database', 'user', 'password')`
`624`	`624`	`findMySQLDatabaseSecretArguments();`
`625`	`625`	`}`
`626`		`- else if (engine_name == "S3")`
	`626`	`+ else if (engine_name == "S3" \|\| engine_name == "DataLakeCatalog")`
`627`	`627`	`{`
`628`	`628`	`/// S3('url', 'access_key_id', 'secret_access_key')`
`629`	`629`	`findS3DatabaseSecretArguments();`
Original file line number	Diff line number	Diff line change
`@@ -138,6 +138,9 @@ def create_clickhouse_iceberg_database(`
`138`	`138`	`SETTINGS {",".join((k+"="+repr(v) for k, v in settings.items()))}`
`139`	`139`	`"""`
`140`	`140`	`)`
	`141`	`+ show_result = node.query(f"SHOW DATABASE {name}")`
	`142`	`+ assert minio_secret_key not in show_result`
	`143`	`+ assert "HIDDEN" in show_result`
`141`	`144`
`142`	`145`
`143`	`146`	`def print_objects():`