Skip to content

Commit 18fbb0c

Browse files
committed
Deprecate storage level setting
1 parent a6e76a0 commit 18fbb0c

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

src/Storages/ObjectStorage/DataLakes/DeltaLakeMetadata.h

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ namespace DB
1818
{
1919
namespace StorageObjectStorageSetting
2020
{
21-
extern const StorageObjectStorageSettingsBool allow_experimental_delta_kernel_rs;
2221
extern const StorageObjectStorageSettingsBool delta_lake_read_schema_same_as_table_schema;
2322
}
2423
namespace Setting
@@ -72,9 +71,7 @@ class DeltaLakeMetadata final : public IDataLakeMetadata
7271
const auto storage_type = configuration_ptr->getType();
7372
const bool supports_delta_kernel = storage_type == ObjectStorageType::S3 || storage_type == ObjectStorageType::Local;
7473

75-
bool enable_delta_kernel = storage_settings_ref[StorageObjectStorageSetting::allow_experimental_delta_kernel_rs]
76-
|| query_settings_ref[Setting::allow_experimental_delta_kernel_rs];
77-
74+
bool enable_delta_kernel = query_settings_ref[Setting::allow_experimental_delta_kernel_rs];
7875
if (supports_delta_kernel && enable_delta_kernel)
7976
{
8077
return std::make_unique<DeltaLakeMetadataDeltaKernel>(

src/Storages/ObjectStorage/StorageObjectStorageSettings.h

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,6 @@ class SettingsChanges;
4949
#define STORAGE_OBJECT_STORAGE_RELATED_SETTINGS(DECLARE, ALIAS) \
5050
DECLARE(Bool, allow_dynamic_metadata_for_data_lakes, false, R"(
5151
If enabled, indicates that metadata is taken from iceberg specification that is pulled from cloud before each query.
52-
)", 0) \
53-
DECLARE(Bool, allow_experimental_delta_kernel_rs, true, R"(
54-
If enabled, the engine would use delta-kernel-rs for DeltaLake metadata parsing
5552
)", 0) \
5653
DECLARE(Bool, delta_lake_read_schema_same_as_table_schema, false, R"(
5754
Whether delta-lake read schema is the same as table schema.
@@ -69,6 +66,9 @@ If enabled, the engine would use the metadata file with the most recent last_upd
6966
Get latest metadata path from version-hint.text file.
7067
)", 0) \
7168

69+
#define OBSOLETE_SETTINGS(M, ALIAS) \
70+
MAKE_OBSOLETE(M, Bool, allow_experimental_delta_kernel_rs, true) \
71+
7272
// clang-format on
7373

7474
STORAGE_OBJECT_STORAGE_SETTINGS_SUPPORTED_TYPES(StorageObjectStorageSettings, DECLARE_SETTING_TRAIT)
@@ -98,6 +98,7 @@ using StorageObjectStorageSettingsPtr = std::shared_ptr<StorageObjectStorageSett
9898

9999
#define LIST_OF_STORAGE_OBJECT_STORAGE_SETTINGS(M, ALIAS) \
100100
STORAGE_OBJECT_STORAGE_RELATED_SETTINGS(M, ALIAS) \
101+
OBSOLETE_SETTINGS(M, ALIAS) \
101102
LIST_OF_ALL_FORMAT_SETTINGS(M, ALIAS)
102103

103104
}

0 commit comments

Comments
 (0)