Merge pull request ClickHouse#79046 from ClickHouse/insertion-table

Fix storage of insertion table in client context

Author: GrigoryPervakov

src/Client/ClientBase.cpp

@@ -71,6 +71,7 @@
 
 #include <Access/AccessControl.h>
 #include <Storages/ColumnsDescription.h>
+#include <TableFunctions/ITableFunction.h>
 
 #include <filesystem>
 #include <iostream>
@@ -1706,13 +1707,21 @@ bool ClientBase::receiveSampleBlock(Block & out, ColumnsDescription & columns_de
 
 void ClientBase::setInsertionTable(const ASTInsertQuery & insert_query)
 {
-    if (!client_context->hasInsertionTable() && insert_query.table)
+    if (!client_context->hasInsertionTable())
     {
-        String table = insert_query.table->as<ASTIdentifier &>().shortName();
-        if (!table.empty())
+        if  (insert_query.table)
         {
-            String database = insert_query.database ? insert_query.database->as<ASTIdentifier &>().shortName() : "";
-            client_context->setInsertionTable(StorageID(database, table));
+            String table = insert_query.table->as<ASTIdentifier &>().shortName();
+            if (!table.empty())
+            {
+                String database = insert_query.database ? insert_query.database->as<ASTIdentifier &>().shortName() : "";
+                client_context->setInsertionTable(StorageID(database, table));
+            }
+        }
+        else if (insert_query.table_function)
+        {
+            String table_function = insert_query.table_function->as<ASTFunction &>().name;
+            client_context->setInsertionTable(StorageID(ITableFunction::getDatabaseName(), table_function));
         }
     }
 }
@@ -2160,6 +2169,7 @@ void ClientBase::processParsedSingleQuery(
     cancelled_printed = false;
     client_exception.reset();
     server_exception.reset();
+    client_context->setInsertionTable(StorageID::createEmpty());
 
     if (is_interactive)
     {

src/Interpreters/processColumnTransformers.cpp

@@ -64,6 +64,9 @@ ASTPtr processColumnTransformers(
         const ColumnsDescription & columns,
         ASTPtr query_columns)
 {
+    if (table_id.empty())
+        return processColumnTransformersImpl(columns, {}, query_columns, current_database, StorageID("", "dummy"));
+
     return processColumnTransformersImpl(columns, {}, query_columns, current_database, table_id);
 }
 

tests/queries/0_stateless/02878_use_structure_from_insertion_table_with_explicit_insert_columns.reference

@@ -5,3 +5,4 @@
 42	world
 42	world
 42	world
+42	world

tests/queries/0_stateless/02878_use_structure_from_insertion_table_with_explicit_insert_columns.sh

@@ -17,13 +17,14 @@ select * from test order by x;
 rm $CLICKHOUSE_TEST_UNIQUE_NAME.native
 
 $CLICKHOUSE_LOCAL -q "select 'world' as y, 42 as x format Values" > $CLICKHOUSE_TEST_UNIQUE_NAME.values
-$CLICKHOUSE_LOCAL -q "
+$CLICKHOUSE_CLIENT -q "
+drop table if exists test_infile;
 create table test_infile (val UInt64, key String) engine=Memory;
-insert into test_infile select * from file('$CLICKHOUSE_TEST_UNIQUE_NAME.values'); -- { serverError CANNOT_PARSE_TEXT }
 insert into test_infile from infile '$CLICKHOUSE_TEST_UNIQUE_NAME.values' FORMAT Values; -- { clientError CANNOT_PARSE_TEXT }
 insert into test_infile (key, val) from infile '$CLICKHOUSE_TEST_UNIQUE_NAME.values' FORMAT Values;
 insert into test_infile (* EXCEPT 'val', * EXCEPT 'key') from infile '$CLICKHOUSE_TEST_UNIQUE_NAME.values' FORMAT Values;
 insert into test_infile (* EXCEPT 'val', test_infile.val) from infile '$CLICKHOUSE_TEST_UNIQUE_NAME.values' FORMAT Values;
+insert into table function remote('localhost:9000', $CLICKHOUSE_DATABASE.test_infile) (remote.key, _table_function.remote.val) from infile '$CLICKHOUSE_TEST_UNIQUE_NAME.values' FORMAT Values;
 select * from test_infile order by key, val;
 "