Skip to content

Commit 348c65e

Browse files
committed
fixed
1 parent 39a6676 commit 348c65e

File tree

5 files changed

+7
-4
lines changed

5 files changed

+7
-4
lines changed

docs/en/operations/server-configuration-parameters/_server_settings_outside_source.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -244,6 +244,7 @@ To manually turn on error history collection [`system.error_log`](../../operatio
244244
<reserved_size_rows>8192</reserved_size_rows>
245245
<buffer_size_rows_flush_threshold>524288</buffer_size_rows_flush_threshold>
246246
<flush_on_crash>false</flush_on_crash>
247+
<symbolize>true</symbolize>
247248
</error_log>
248249
</clickhouse>
249250
```

src/Common/SymbolsHelper.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88
namespace DB
99
{
1010

11-
std::pair<Array, Array> generateArraysSymbolsLines(const std::vector<UInt64> trace) {
11+
std::pair<Array, Array> generateArraysSymbolsLines(const std::vector<UInt64> & trace)
12+
{
1213
Array symbols;
1314
Array lines;
1415
size_t num_frames = trace.size();

src/Common/SymbolsHelper.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
namespace DB
1010
{
1111

12-
std::pair<Array, Array> generateArraysSymbolsLines(const std::vector<UInt64> trace);
12+
std::pair<Array, Array> generateArraysSymbolsLines(const std::vector<UInt64> & trace);
1313

1414
}
1515
#endif

src/Interpreters/ErrorLog.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
#include <Parsers/parseQuery.h>
1313
#include <Common/SymbolsHelper.h>
1414

15-
#include <vector>
1615

1716
namespace DB
1817
{

src/Interpreters/ErrorLog.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
#include <DataTypes/DataTypeArray.h>
88
#include <Storages/ColumnsDescription.h>
99

10+
#include <vector>
11+
1012

1113
namespace DB
1214
{
@@ -23,7 +25,7 @@ struct ErrorLogElement
2325
ErrorCodes::Value value{};
2426
bool remote{};
2527
std::string_view query_id;
26-
ErrorCodes::FramePointers error_trace{};
28+
std::vector<void *> error_trace{};
2729
bool symbolize = false;
2830

2931
static std::string name() { return "ErrorLog"; }

0 commit comments

Comments
 (0)