Prevent another LOGICAL_ERROR due to aliases

Author: Algunenano

src/Interpreters/TreeRewriter.cpp

@@ -365,6 +365,10 @@ void renameDuplicatedColumns(const ASTSelectQuery * select_query)
 
     for (auto & expr : elements)
     {
+        /// We can't rename with aliases if it doesn't support alias (e.g. asterisk)
+        if (!expr->as<ASTWithAlias>())
+            continue;
+
         auto name = expr->getAliasOrColumnName();
 
         if (!assigned_column_names.insert(name).second)

tests/queries/0_stateless/03444_explain_asterisk.reference

@@ -0,0 +1,61 @@
+SELECT
+    `_--t1.a` AS `t1.a`,
+    `_--t1.b` AS `t1.b`,
+    `_--t2.a` AS `t2.a`,
+    `_--t2.b` AS `t2.b`,
+    `toNullable(10)` AS `t3.toNullable(10)`,
+    `_--t3.a` AS `t3.a`,
+    `_--t3.b` AS `t3.b`,
+    `isZeroOrNull(10)` AS `t3.isZeroOrNull(10)`,
+    `_--t3.10` AS `t3.10`,
+    `assumeNotNull(materialize(10))` AS `t3.assumeNotNull(materialize(10))`,
+    `isNotNull(10)` AS `t3.isNotNull(10)`,
+    x AS `t3.x`
+FROM
+(
+    SELECT
+        b AS `_--t1.b`,
+        a AS `_--t1.a`,
+        t2.b AS `_--t2.b`,
+        t2.a AS `_--t2.a`
+    FROM t1
+    ALL INNER JOIN
+    (
+        SELECT
+            a,
+            b
+        FROM t2
+    ) AS t2 ON if(`_--t2.b` > 0, `_--t2.a`, 0) = `_--t1.a`
+    WHERE if(`_--t2.b` > 0, `_--t2.a`, 0) = `_--t1.a`
+) AS `--.s`
+CROSS JOIN
+(
+    SELECT
+        x,
+        `assumeNotNull(materialize(10))`,
+        `isNotNull(10)`,
+        `isZeroOrNull(10)`,
+        `toNullable(10)`,
+        `10` AS `_--t3.10`,
+        b AS `_--t3.b`,
+        a AS `_--t3.a`
+    FROM
+    (
+        SELECT
+            toNullable(10),
+            a,
+            b,
+            isZeroOrNull(10),
+            10,
+            assumeNotNull(materialize(10)),
+            10 IS NOT NULL,
+            a AS x
+        FROM t3__fuzz_0
+        WHERE (toNullable(toUInt256(1)) + a) = b
+    ) AS t3
+) AS `--.t`
+WHERE if(`_--t2.b` > 0, `_--t2.a`, 0) = `_--t1.a`
+ORDER BY
+    x ASC NULLS FIRST,
+    `_--t2.a` DESC NULLS LAST,
+    `_--t1.a` DESC NULLS FIRST

tests/queries/0_stateless/03444_explain_asterisk.sql

@@ -0,0 +1,6 @@
+-- Fuzzing `Can't set alias of * of Asterisk on alias`
+DROP TABLE IF EXISTS t1, t2, t3__fuzz_0;
+CREATE TABLE t1 (`a` UInt64, `b` UInt64) ENGINE = Log;
+CREATE TABLE t2 (`a` UInt64, `b` UInt64) ENGINE = Log;
+CREATE TABLE t3__fuzz_0 (`a` LowCardinality(UInt64), `b` UInt64) ENGINE = Log SETTINGS allow_suspicious_low_cardinality_types=1;
+EXPLAIN SYNTAX  SELECT * FROM t1, t2, (SELECT toNullable(10), *, isZeroOrNull(10), 10, *, 10, *, *, 10, *, *, *, assumeNotNull(materialize(10)), 10 IS NOT NULL, a AS x FROM t3__fuzz_0 WHERE (toNullable(toUInt256(1)) + a) = b) AS t3 WHERE if(t2.b > 0, t2.a, 0) = t1.a ORDER BY t3.x ASC NULLS FIRST, t2.a DESC NULLS LAST, t1.a DESC NULLS FIRST;