Skip to content

Commit 3cb622a

Browse files
committed
Hopefully also fix '/test/re/max_log_ptr': node doesn't exist
1 parent 397a143 commit 3cb622a

File tree

1 file changed

+23
-22
lines changed
  • tests/integration/test_refreshable_mv

1 file changed

+23
-22
lines changed

tests/integration/test_refreshable_mv/test.py

Lines changed: 23 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@
4040
)
4141
nodes = [node1, node2]
4242

43+
test_idx = 0
44+
4345

4446
@pytest.fixture(scope="module")
4547
def started_cluster():
@@ -50,11 +52,22 @@ def started_cluster():
5052
finally:
5153
cluster.shutdown()
5254

55+
@pytest.fixture
56+
def cleanup():
57+
yield
58+
59+
for node in nodes:
60+
node.query(
61+
"drop database if exists re sync;"
62+
"drop table if exists system.a;")
63+
64+
global test_idx
65+
test_idx += 1
5366

54-
def test_refreshable_mv_in_replicated_db(started_cluster):
67+
def test_refreshable_mv_in_replicated_db(started_cluster, cleanup):
5568
for node in nodes:
5669
node.query(
57-
"create database re engine = Replicated('/test/re', 'shard1', '{replica}');"
70+
f"create database re engine = Replicated('/test/re_{test_idx}', 'shard1', '{{replica}}');"
5871
)
5972

6073
# Table engine check.
@@ -212,11 +225,8 @@ def test_refreshable_mv_in_replicated_db(started_cluster):
212225
for node in nodes:
213226
assert node.query("show tables from re") == ""
214227

215-
node1.query("drop database re sync")
216-
node2.query("drop database re sync")
217228

218-
219-
def test_refreshable_mv_in_system_db(started_cluster):
229+
def test_refreshable_mv_in_system_db(started_cluster, cleanup):
220230
node1.query(
221231
"create materialized view system.a refresh every 1 second (x Int64) engine Memory as select number+1 as x from numbers(2);"
222232
"system refresh view system.a;"
@@ -226,17 +236,15 @@ def test_refreshable_mv_in_system_db(started_cluster):
226236
node1.query("system refresh view system.a")
227237
assert node1.query("select count(), sum(x) from system.a") == "2\t3\n"
228238

229-
node1.query("drop table system.a")
230-
231-
def test_refreshable_mv_in_read_only_node(started_cluster):
239+
def test_refreshable_mv_in_read_only_node(started_cluster, cleanup):
232240
# writable node
233241
node1.query(
234-
"create database re engine = Replicated('/test/re', 'shard1', '{replica}');"
242+
f"create database re engine = Replicated('/test/re_{test_idx}', 'shard1', '{{replica}}');"
235243
)
236244

237245
# read_only node
238246
reading_node.query(
239-
"create database re engine = Replicated('/test/re', 'shard1', '{replica}');"
247+
f"create database re engine = Replicated('/test/re_{test_idx}', 'shard1', '{{replica}}');"
240248
)
241249

242250
# disable view sync on writable node, see if there's RefreshTask on read_only node
@@ -280,13 +288,10 @@ def test_refreshable_mv_in_read_only_node(started_cluster):
280288
"1\n",
281289
)
282290

283-
reading_node.query("drop database re sync")
284-
node1.query("drop database re sync")
285-
286-
def test_refresh_vs_shutdown_smoke(started_cluster):
291+
def test_refresh_vs_shutdown_smoke(started_cluster, cleanup):
287292
for node in nodes:
288293
node.query(
289-
"create database re engine = Replicated('/test/re', 'shard1', '{replica}');"
294+
f"create database re engine = Replicated('/test/re_{test_idx}', 'shard1', '{{replica}}');"
290295
)
291296

292297
node1.stop_clickhouse()
@@ -331,13 +336,11 @@ def test_refresh_vs_shutdown_smoke(started_cluster):
331336
)
332337

333338
node1.start_clickhouse()
334-
node1.query("drop database re sync")
335-
node2.query("drop database re sync")
336339

337-
def test_replicated_db_startup_race(started_cluster):
340+
def test_replicated_db_startup_race(started_cluster, cleanup):
338341
for node in nodes:
339342
node.query(
340-
"create database re engine = Replicated('/test/re', 'shard1', '{replica}');"
343+
f"create database re engine = Replicated('/test/re_{test_idx}', 'shard1', '{{replica}}');"
341344
)
342345
node1.query(
343346
"create materialized view re.a refresh every 1 second (x Int64) engine ReplicatedMergeTree order by x as select number*10 as x from numbers(2);\
@@ -354,5 +357,3 @@ def test_replicated_db_startup_race(started_cluster):
354357
node1.query("system disable failpoint database_replicated_startup_pause")
355358
_, err = drop_query_handle.get_answer_and_error()
356359
assert err == ""
357-
358-
node2.query("drop database re sync")

0 commit comments

Comments
 (0)