Fix __actionName, add tests for internal functions direct call

Author: vdimir

src/Functions/identity.h

@@ -53,7 +53,7 @@ class FunctionActionName : public FunctionIdentityBase<ActionNameName>
     using FunctionIdentityBase::FunctionIdentityBase;
     static FunctionPtr create(ContextPtr) { return std::make_shared<FunctionActionName>(); }
     size_t getNumberOfArguments() const override { return 2; }
-    ColumnNumbers getArgumentsThatAreAlwaysConstant() const override { return {1}; }
+    ColumnNumbers getArgumentsThatAreAlwaysConstant() const override { return {0, 1}; }
 };
 
 }

src/Planner/PlannerActionsVisitor.cpp

@@ -159,7 +159,17 @@ class ActionNodeNameHelper
                 const auto & function_node = node->as<FunctionNode &>();
                 if (function_node.getFunctionName() == "__actionName")
                 {
-                    result = toString(function_node.getArguments().getNodes().at(1)->as<ConstantNode>()->getValue());
+                    /// Perform sanity check, because user may call this function with unexpected arguments
+                    const auto & function_argument_nodes = function_node.getArguments().getNodes();
+                    if (function_argument_nodes.size() == 2)
+                    {
+                        if (const auto * second_argument = function_argument_nodes.at(1)->as<ConstantNode>())
+                            result = toString(second_argument->getValue());
+                    }
+
+                    /// Empty node name is not allowed and leads to logical errors
+                    if (result.empty())
+                        throw Exception(ErrorCodes::BAD_ARGUMENTS, "Function __actionName is internal nad should not be used directly");
                     break;
                 }
 

tests/queries/0_stateless/03035_internal_functions_direct_call.reference

@@ -0,0 +1,5 @@
+aaa
+(1,1)	(1,1)
+1
+a1	1
+1

tests/queries/0_stateless/03035_internal_functions_direct_call.sql

@@ -0,0 +1,23 @@
+-- This functions should not be called directly, only for internal use.
+-- However, we cannot completely forbid it (becasue query can came from another server, for example)
+-- Check that usage of these functions does not lead to crash or logical error
+
+SELECT __actionName(); -- { serverError NUMBER_OF_ARGUMENTS_DOESNT_MATCH }
+SELECT __actionName('aaa', 'aaa', 'aaa'); -- { serverError NUMBER_OF_ARGUMENTS_DOESNT_MATCH }
+SELECT __actionName('aaa', '') SETTINGS allow_experimental_analyzer = 1; -- { serverError BAD_ARGUMENTS }
+SELECT __actionName('aaa', materialize('aaa')); -- { serverError BAD_ARGUMENTS,ILLEGAL_COLUMN }
+SELECT __actionName(materialize('aaa'), 'aaa'); -- { serverError ILLEGAL_COLUMN }
+SELECT __actionName('aaa', 'aaa');
+
+SELECT __getScalar('aaa'); -- { serverError BAD_ARGUMENTS }
+SELECT __getScalar(); -- { serverError NUMBER_OF_ARGUMENTS_DOESNT_MATCH }
+SELECT __getScalar(1); -- { serverError ILLEGAL_TYPE_OF_ARGUMENT }
+SELECT __getScalar(materialize('1')); -- { serverError ILLEGAL_TYPE_OF_ARGUMENT }
+
+WITH ( SELECT (1,1) ) as a SELECT materialize(a), __getScalar('17789833925953107877_7493841889429261611') SETTINGS allow_experimental_analyzer = 1;
+
+SELECT __scalarSubqueryResult('1');
+SELECT 'a' || __scalarSubqueryResult(a), materialize('1') as a;
+SELECT __scalarSubqueryResult(a, a), materialize('1') as a; -- { serverError NUMBER_OF_ARGUMENTS_DOESNT_MATCH }
+
+SELECT 1 as `__grouping_set`;