onFinish is concurrent with cancel, 2

CheSema · CheSema · commit 4effd9dd4eb2 · 2025-04-25T17:55:12.000+02:00
diff --git a/src/Storages/MergeTree/MergeTreeSink.cpp b/src/Storages/MergeTree/MergeTreeSink.cpp
@@ -64,7 +64,8 @@ void MergeTreeSink::onStart()
 
 void MergeTreeSink::onFinish()
 {
-    chassert(!isCancelled());
+    if (isCancelled())
+        return;
 
     finishDelayedChunk();
 }

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,8 @@ void MergeTreeSink::onStart()`
`64`	`64`
`65`	`65`	`void MergeTreeSink::onFinish()`
`66`	`66`	`{`
`67`		`- chassert(!isCancelled());`
	`67`	`+ if (isCancelled())`
	`68`	`+ return;`
`68`	`69`
`69`	`70`	`finishDelayedChunk();`
`70`	`71`	`}`