Merge pull request ClickHouse#77319 from Avogar/fix-bool-partition

Fix name for partition with a Bool value

Author: Avogar

src/DataTypes/Serializations/SerializationBool.cpp

@@ -225,7 +225,8 @@ ReturnType deserializeImpl(
 void SerializationBool::deserializeBinary(DB::Field & field, DB::ReadBuffer & istr, const DB::FormatSettings & settings) const
 {
     nested_serialization->deserializeBinary(field, istr, settings);
-    field = bool(field.safeGet<bool>());
+    if (!settings.binary.read_bool_field_as_int)
+        field = bool(field.safeGet<bool>());
 }
 
 SerializationBool::SerializationBool(const SerializationPtr &nested_)

src/Formats/FormatSettings.h

@@ -127,6 +127,7 @@ struct FormatSettings
         bool decode_types_in_binary_format = false;
         bool read_json_as_string = false;
         bool write_json_as_string = false;
+        bool read_bool_field_as_int = false;
     } binary{};
 
     struct

src/Storages/MergeTree/MergeTreePartition.cpp

@@ -416,9 +416,12 @@ void MergeTreePartition::load(const IMergeTreeDataPart & part)
     const auto & partition_key_sample = adjustPartitionKey(metadata_snapshot, part.storage.getContext()).sample_block;
 
     auto file = part.readFile("partition.dat");
+    FormatSettings settings;
+    /// For compatibility we should read values of Bool data type as 0/1 int Field, not as bool true/false Field.
+    settings.binary.read_bool_field_as_int = true;
     value.resize(partition_key_sample.columns());
     for (size_t i = 0; i < partition_key_sample.columns(); ++i)
-        partition_key_sample.getByPosition(i).type->getDefaultSerialization()->deserializeBinary(value[i], *file, {});
+        partition_key_sample.getByPosition(i).type->getDefaultSerialization()->deserializeBinary(value[i], *file, settings);
 }
 
 std::unique_ptr<WriteBufferFromFileBase> MergeTreePartition::store(

tests/queries/0_stateless/03375_bool_partition.reference

@@ -0,0 +1,3 @@
+0_1_1_0
+1_2_2_0
+false

tests/queries/0_stateless/03375_bool_partition.sql

@@ -0,0 +1,8 @@
+DROP TABLE IF EXISTS t0;
+CREATE TABLE t0 (c0 Bool) ENGINE = MergeTree() ORDER BY tuple() PARTITION BY (c0);
+INSERT INTO TABLE t0 (c0) VALUES (FALSE), (TRUE);
+SELECT part_name FROM system.parts where table='t0' and database=currentDatabase();
+DELETE FROM t0 WHERE c0;
+SELECT c0 FROM t0;
+DROP TABLE t0;
+