Fix proper detection of virtual base class

Author: Algunenano

src/Interpreters/OptimizeIfWithConstantConditionVisitor.cpp

@@ -98,7 +98,7 @@ void OptimizeIfWithConstantConditionVisitorData::visit(ASTFunction & function_no
     if (tryExtractConstValueFromCondition(condition_expr, condition))
     {
         ASTPtr replace_ast = condition ? then_expr : else_expr;
-        bool replacement_supports_alias = replace_ast->as<ASTWithAlias>() != nullptr;
+        bool replacement_supports_alias = dynamic_cast<ASTWithAlias *>(replace_ast.get());
         String if_alias = ast->tryGetAlias();
         /// We cannot set the resulting alias if the replace ast does not support it (e.g. ASTAsterisk), so it's better to do nothing
         if (!if_alias.empty() && !replacement_supports_alias)

src/Interpreters/TreeRewriter.cpp

@@ -365,14 +365,13 @@ void renameDuplicatedColumns(const ASTSelectQuery * select_query)
 
     for (auto & expr : elements)
     {
-        /// We can't rename with aliases if it doesn't support alias (e.g. asterisk)
-        if (!expr->as<ASTWithAlias>())
-            continue;
-
         auto name = expr->getAliasOrColumnName();
-
         if (!assigned_column_names.insert(name).second)
         {
+            /// We can't rename with aliases if it doesn't support alias (e.g. asterisk)
+            if (!dynamic_cast<ASTWithAlias *>(expr.get()))
+                continue;
+
             size_t i = 1;
             while (all_column_names.end() != all_column_names.find(name + "_" + toString(i)))
                 ++i;

tests/queries/0_stateless/03444_explain_asterisk.reference

@@ -47,6 +47,8 @@ CROSS JOIN
             b,
             isZeroOrNull(10),
             10,
+            10 AS `10_1`,
+            10 AS `10_2`,
             assumeNotNull(materialize(10)),
             10 IS NOT NULL,
             a AS x