Merge pull request ClickHouse#79954 from jkartseva/fix-azure-ro-merges

Respect readonly setting in Azure Blob Storage

Author: jkartseva

src/Disks/ObjectStorages/AzureBlobStorage/AzureBlobStorageCommon.cpp

@@ -442,6 +442,7 @@ std::unique_ptr<RequestSettings> getRequestSettings(const Poco::Util::AbstractCo
 
     settings->min_bytes_for_seek = config.getUInt64(config_prefix + ".min_bytes_for_seek", 1024 * 1024);
     settings->use_native_copy = config.getBool(config_prefix + ".use_native_copy", false);
+    settings->read_only = config.getBool(config_prefix + ".readonly", false);
 
     settings->max_single_part_upload_size = config.getUInt64(config_prefix + ".max_single_part_upload_size", settings_ref[Setting::azure_max_single_part_upload_size]);
     settings->max_single_read_retries = config.getUInt64(config_prefix + ".max_single_read_retries", settings_ref[Setting::azure_max_single_read_retries]);

src/Disks/ObjectStorages/AzureBlobStorage/AzureBlobStorageCommon.h

@@ -50,6 +50,7 @@ struct RequestSettings
     size_t sdk_retry_max_backoff_ms = 1000;
     bool use_native_copy = false;
     bool check_objects_after_upload = false;
+    bool read_only = false;
 
     using CurlOptions = Azure::Core::Http::CurlTransportOptions;
     CurlOptions::CurlOptIPResolve curl_ip_resolve = CurlOptions::CURL_IPRESOLVE_WHATEVER;

src/Disks/ObjectStorages/AzureBlobStorage/AzureObjectStorage.h

@@ -100,6 +100,8 @@ class AzureObjectStorage : public IObjectStorage
     std::shared_ptr<const AzureBlobStorage::RequestSettings> getSettings() const  { return settings.get(); }
     std::shared_ptr<const AzureBlobStorage::ContainerClient> getAzureBlobStorageClient() const override { return client.get(); }
 
+    bool isReadOnly() const override { return settings.get()->read_only; }
+
     bool supportParallelWrite() const override { return true; }
 
 private:

tests/queries/0_stateless/03457_azure_readonly_disk.reference

@@ -0,0 +1 @@
+Disk is read only	1

tests/queries/0_stateless/03457_azure_readonly_disk.sh

@@ -0,0 +1,34 @@
+#!/usr/bin/env bash
+# Tags: no-fasttest, no-distributed-cache
+# Tag no-fasttest: requires Azure
+# Tag no-distributed-cache: Not supported auth type
+
+CUR_DIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
+# shellcheck source=../shell_config.sh
+. "$CUR_DIR"/../shell_config.sh
+
+CONTAINER="cont-$(echo "${CLICKHOUSE_TEST_UNIQUE_NAME}" | tr _ -)"
+
+DISK_NAME="$CONTAINER"
+
+$CLICKHOUSE_CLIENT -m -q "
+    DROP TABLE IF EXISTS test_azure_readonly;
+
+    CREATE TABLE test_azure_readonly (key Int, arr Array(UInt32)) ENGINE=MergeTree() ORDER BY tuple()
+        SETTINGS
+            disk = disk(
+                readonly = true,
+                type = object_storage,
+                metadata_type = local,
+                object_storage_type = azure_blob_storage,
+                name = '${DISK_NAME}',
+                path='/var/lib/clickhouse/disks/${CONTAINER}/tables',
+                container_name = '${CONTAINER}',
+                endpoint = 'http://localhost:10000/devstoreaccount1/${CONTAINER}/tables',
+                account_name = 'devstoreaccount1',
+                account_key = 'Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==');
+    INSERT INTO test_azure_readonly SELECT *, [] from numbers(1); -- { serverError TABLE_IS_READ_ONLY }
+    OPTIMIZE TABLE test_azure_readonly FINAL; -- { serverError TABLE_IS_READ_ONLY }
+    SELECT 'Disk is read only', is_read_only FROM system.disks WHERE name = '${DISK_NAME}';
+    DROP TABLE test_azure_readonly SYNC;
+"