Skip to content

Commit 6f6bf9f

Browse files
committed
sync settings and profile events
1 parent bb07aa5 commit 6f6bf9f

File tree

3 files changed

+12
-4
lines changed

3 files changed

+12
-4
lines changed

src/Common/ProfileEvents.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,9 +140,10 @@
140140
M(PatchesAppliedInAllReadTasks, "Total number of applied patch parts among all read tasks", ValueType::Number) \
141141
M(PatchesMergeAppliedInAllReadTasks, "Total number of applied patch parts with Merge mode among all read tasks", ValueType::Number) \
142142
M(PatchesJoinAppliedInAllReadTasks, "Total number of applied patch parts with Join mode among all read tasks", ValueType::Number) \
143-
M(ApplyPatchesMicroseconds, "Total time spent applying patch parts", ValueType::Number) \
144-
M(ApplyPatchesMergeMicroseconds, "Total time spent applying patch parts with Merge mode", ValueType::Number) \
145-
M(ApplyPatchesJoinMicroseconds, "Total time spent applying patch parts with Join mode", ValueType::Number) \
143+
M(ApplyPatchesMicroseconds, "Total time spent applying patch parts to blocks", ValueType::Number) \
144+
M(ReadPatchesMicroseconds, "Total time spent reading patch parts", ValueType::Number) \
145+
M(BuildPatchesMergeMicroseconds, "Total time spent building indexes for applying patch parts with Merge mode", ValueType::Number) \
146+
M(BuildPatchesJoinMicroseconds, "Total time spent building indexes and hash tables for applying patch parts with Join mode", ValueType::Number) \
146147
M(AnalyzePatchRangesMicroseconds, "Total time spent analyzing index of patch parts", ValueType::Number) \
147148
M(ReadTasksWithAppliedMutationsOnFly, "Total number of read tasks for which there was any mutation applied on fly", ValueType::Number) \
148149
M(MutationsAppliedOnFlyInAllReadTasks, "Total number of applied mutations on-fly among all read tasks", ValueType::Number) \

src/Core/SettingsChangesHistory.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -761,7 +761,7 @@ const VersionToSettingsChangesMap & getMergeTreeSettingsChangesHistory()
761761
{
762762
addSettingsChanges(merge_tree_settings_changes_history, "25.6",
763763
{
764-
764+
{"cache_populated_by_fetch_filename_regexp", "", "", "New setting"},
765765
});
766766
addSettingsChanges(merge_tree_settings_changes_history, "25.5",
767767
{

src/Storages/MergeTree/MergeTreeSettings.cpp

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1634,6 +1634,13 @@ namespace ErrorCodes
16341634
- [prefer_warmed_unmerged_parts_seconds](/operations/settings/settings#prefer_warmed_unmerged_parts_seconds)
16351635
- [cache_warmer_threads](/operations/settings/settings#cache_warmer_threads)
16361636
)", 0) \
1637+
DECLARE(String, cache_populated_by_fetch_filename_regexp, "", R"(
1638+
:::note
1639+
This setting applies only to ClickHouse Cloud.
1640+
:::
1641+
1642+
If not empty, only files that match this regex will be prewarmed into the cache after fetch (if `cache_populated_by_fetch` is enabled).
1643+
)", 0) \
16371644
DECLARE(Bool, allow_experimental_replacing_merge_with_cleanup, false, R"(
16381645
Allow experimental CLEANUP merges for ReplacingMergeTree with `is_deleted`
16391646
column. When enabled, allows using `OPTIMIZE ... FINAL CLEANUP` to manually

0 commit comments

Comments
 (0)