Skip to content

Commit 73fe339

Browse files
author
Alex Katsman
committed
Increase defaults
1 parent 502a349 commit 73fe339

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

src/Core/ServerSettings.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1059,8 +1059,8 @@ The policy on how to perform a scheduling of CPU slots specified by `concurrent_
10591059
DECLARE(Bool, storage_shared_set_join_use_inner_uuid, true, "If enabled, an inner UUID is generated during the creation of SharedSet and SharedJoin. ClickHouse Cloud only", 0) \
10601060
DECLARE(UInt64, startup_mv_delay_ms, 0, R"(Debug parameter to simulate materizlied view creation delay)", 0) \
10611061
DECLARE(UInt64, os_cpu_busy_time_threshold, 1'000'000, "Threshold of OS CPU busy time in microseconds (OSCPUVirtualTimeMicroseconds metric) to consider CPU doing some useful work, no CPU overload would be considered if busy time was below this value.", 0) \
1062-
DECLARE(Float, min_os_cpu_wait_time_ratio_to_drop_connection, 10.0, "Min ratio between OS CPU wait (OSCPUWaitMicroseconds metric) and busy (OSCPUVirtualTimeMicroseconds metric) times to consider dropping connections. Linear interpolation between min and max ratio is used to calculate the probability, the probability is 0 at this point.", 0) \
1063-
DECLARE(Float, max_os_cpu_wait_time_ratio_to_drop_connection, 20.0, "Max ratio between OS CPU wait (OSCPUWaitMicroseconds metric) and busy (OSCPUVirtualTimeMicroseconds metric) times to consider dropping connections. Linear interpolation between min and max ratio is used to calculate the probability, the probability is 1 at this point.", 0) \
1062+
DECLARE(Float, min_os_cpu_wait_time_ratio_to_drop_connection, 15.0, "Min ratio between OS CPU wait (OSCPUWaitMicroseconds metric) and busy (OSCPUVirtualTimeMicroseconds metric) times to consider dropping connections. Linear interpolation between min and max ratio is used to calculate the probability, the probability is 0 at this point.", 0) \
1063+
DECLARE(Float, max_os_cpu_wait_time_ratio_to_drop_connection, 30.0, "Max ratio between OS CPU wait (OSCPUWaitMicroseconds metric) and busy (OSCPUVirtualTimeMicroseconds metric) times to consider dropping connections. Linear interpolation between min and max ratio is used to calculate the probability, the probability is 1 at this point.", 0) \
10641064
DECLARE(Float, distributed_cache_keep_up_free_connections_ratio, 0.1f, "Soft limit for number of active connection distributed cache will try to keep free. After the number of free connections goes below distributed_cache_keep_up_free_connections_ratio * max_connections, connections with oldest activity will be closed until the number goes above the limit.", 0) \
10651065

10661066

src/Core/Settings.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6505,8 +6505,8 @@ File/S3 engines/table function will parse paths with '::' as `<archive> :: <file
65056505
DECLARE(Milliseconds, low_priority_query_wait_time_ms, 1000, R"(
65066506
When the query prioritization mechanism is employed (see setting `priority`), low-priority queries wait for higher-priority queries to finish. This setting specifies the duration of waiting.
65076507
)", BETA) \
6508-
DECLARE(Float, min_os_cpu_wait_time_ratio_to_throw, 2.0, "Min ratio between OS CPU wait (OSCPUWaitMicroseconds metric) and busy (OSCPUVirtualTimeMicroseconds metric) times to consider rejecting queries. Linear interpolation between min and max ratio is used to calculate the probability, the probability is 0 at this point.", 0) \
6509-
DECLARE(Float, max_os_cpu_wait_time_ratio_to_throw, 6.0, "Max ratio between OS CPU wait (OSCPUWaitMicroseconds metric) and busy (OSCPUVirtualTimeMicroseconds metric) times to consider rejecting queries. Linear interpolation between min and max ratio is used to calculate the probability, the probability is 1 at this point.", 0) \
6508+
DECLARE(Float, min_os_cpu_wait_time_ratio_to_throw, 6.0, "Min ratio between OS CPU wait (OSCPUWaitMicroseconds metric) and busy (OSCPUVirtualTimeMicroseconds metric) times to consider rejecting queries. Linear interpolation between min and max ratio is used to calculate the probability, the probability is 0 at this point.", 0) \
6509+
DECLARE(Float, max_os_cpu_wait_time_ratio_to_throw, 10.0, "Max ratio between OS CPU wait (OSCPUWaitMicroseconds metric) and busy (OSCPUVirtualTimeMicroseconds metric) times to consider rejecting queries. Linear interpolation between min and max ratio is used to calculate the probability, the probability is 1 at this point.", 0) \
65106510
\
65116511
/* ####################################################### */ \
65126512
/* ########### START OF EXPERIMENTAL FEATURES ############ */ \

src/Core/SettingsChangesHistory.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,8 @@ const VersionToSettingsChangesMap & getSettingsChangesHistory()
103103
{"cast_string_to_variant_use_inference", true, true, "New setting to enable/disable types inference during CAST from String to Variant"},
104104
{"distributed_cache_read_request_max_tries", 20, 20, "New setting"},
105105
{"query_condition_cache_store_conditions_as_plaintext", false, false, "New setting"},
106-
{"min_os_cpu_wait_time_ratio_to_throw", 0, 2, "New setting"},
107-
{"max_os_cpu_wait_time_ratio_to_throw", 0, 6, "New setting"},
106+
{"min_os_cpu_wait_time_ratio_to_throw", 0, 6, "New setting"},
107+
{"max_os_cpu_wait_time_ratio_to_throw", 0, 10, "New setting"},
108108
{"query_plan_merge_filter_into_join_condition", false, true, "Added new setting to merge filter into join condition"},
109109
{"use_local_cache_for_remote_storage", true, false, "Obsolete setting."},
110110
{"iceberg_timestamp_ms", 0, 0, "New setting."},

src/Interpreters/Context.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -530,8 +530,8 @@ struct ContextSharedPart : boost::noncopyable
530530
/// Only for system.server_settings, actually value stored in reloader itself
531531
std::atomic_size_t config_reload_interval_ms = ConfigReloader::DEFAULT_RELOAD_INTERVAL.count();
532532

533-
double min_os_cpu_wait_time_ratio_to_drop_connection = 10.0;
534-
double max_os_cpu_wait_time_ratio_to_drop_connection = 20.0;
533+
double min_os_cpu_wait_time_ratio_to_drop_connection = 15.0;
534+
double max_os_cpu_wait_time_ratio_to_drop_connection = 30.0;
535535

536536
String format_schema_path; /// Path to a directory that contains schema files used by input formats.
537537
String google_protos_path; /// Path to a directory that contains the proto files for the well-known Protobuf types.

0 commit comments

Comments
 (0)