wrap in try catch

mstetsyuk · mstetsyuk · commit 7c16fe20d18e · 2025-05-15T13:41:04.000Z
diff --git a/src/Common/Exception.cpp b/src/Common/Exception.cpp
@@ -273,12 +273,16 @@ bool Exception::isErrorCodeImportant() const
 }
 
 Exception::~Exception()
+try
 {
     if (logged != nullptr && !logged->load(std::memory_order_relaxed) && isErrorCodeImportant() && isLoggingEnabled())
     {
         LOG_ERROR(getLogger("~Exception"), "{}", getExceptionMessage(*this, /*with_stacktrace=*/ true));
     }
 }
+catch (...)
+{
+}
 
 static void tryLogCurrentExceptionImpl(Poco::Logger * logger, const std::string & start_of_message, LogsLevel level)
 {

Original file line number	Diff line number	Diff line change
`@@ -273,12 +273,16 @@ bool Exception::isErrorCodeImportant() const`
`273`	`273`	`}`
`274`	`274`
`275`	`275`	`Exception::~Exception()`
	`276`	`+try`
`276`	`277`	`{`
`277`	`278`	`if (logged != nullptr && !logged->load(std::memory_order_relaxed) && isErrorCodeImportant() && isLoggingEnabled())`
`278`	`279`	`{`
`279`	`280`	`LOG_ERROR(getLogger("~Exception"), "{}", getExceptionMessage(this, /with_stacktrace=*/ true));`
`280`	`281`	`}`
`281`	`282`	`}`
	`283`	`+catch (...)`
	`284`	`+{`
	`285`	`+}`
`282`	`286`
`283`	`287`	`static void tryLogCurrentExceptionImpl(Poco::Logger * logger, const std::string & start_of_message, LogsLevel level)`
`284`	`288`	`{`