Merge pull request ClickHouse#80154 from ClickHouse/chesema-removeIfNeeded

CheSema · web-flow · commit 7d335b92110d · 2025-05-15T08:52:17.000Z
remove noexcept for removeIfNeeded
diff --git a/src/Storages/MergeTree/IMergeTreeDataPart.cpp b/src/Storages/MergeTree/IMergeTreeDataPart.cpp
@@ -637,7 +637,7 @@ bool IMergeTreeDataPart::mayStoreDataInCaches() const
     return (mark_cache || index_cache) && !cleared_data_in_caches;
 }
 
-void IMergeTreeDataPart::removeIfNeeded() noexcept
+void IMergeTreeDataPart::removeIfNeeded()
 {
     assert(assertHasValidVersionMetadata());
     std::string path;
diff --git a/src/Storages/MergeTree/IMergeTreeDataPart.h b/src/Storages/MergeTree/IMergeTreeDataPart.h
@@ -651,7 +651,7 @@ class IMergeTreeDataPart : public std::enable_shared_from_this<IMergeTreeDataPar
 
     mutable std::map<String, std::shared_ptr<IMergeTreeDataPart>> projection_parts;
 
-    void removeIfNeeded() noexcept;
+    void removeIfNeeded();
 
     /// Fill each_columns_size and total_size with sizes from columns files on
     /// disk using columns and checksums.

Original file line number	Diff line number	Diff line change
`@@ -637,7 +637,7 @@ bool IMergeTreeDataPart::mayStoreDataInCaches() const`
`637`	`637`	`return (mark_cache \|\| index_cache) && !cleared_data_in_caches;`
`638`	`638`	`}`
`639`	`639`
`640`		`-void IMergeTreeDataPart::removeIfNeeded() noexcept`
	`640`	`+void IMergeTreeDataPart::removeIfNeeded()`
`641`	`641`	`{`
`642`	`642`	`assert(assertHasValidVersionMetadata());`
`643`	`643`	`std::string path;`