Merge pull request ClickHouse#78663 from ClickHouse/fix-analyzer-create-view-on-cluster-positional

Fix analyzer: resolve positional arguments in SELECT of CREATE VIEW ... ON CLUSTER

Author: yakov-olkhovskiy

src/Interpreters/InterpreterCreateQuery.cpp

@@ -1109,7 +1109,10 @@ void InterpreterCreateQuery::validateMaterializedViewColumnsAndEngine(const ASTC
         {
             if (getContext()->getSettingsRef()[Setting::allow_experimental_analyzer])
             {
-                input_block = InterpreterSelectQueryAnalyzer::getSampleBlock(create.select->clone(), getContext());
+                /// We should treat SELECT as an initial query in order to properly analyze it.
+                auto context = Context::createCopy(getContext());
+                context->setQueryKindInitial();
+                input_block = InterpreterSelectQueryAnalyzer::getSampleBlock(create.select->clone(), context, SelectQueryOptions{}.createView());
             }
             else
             {

src/Interpreters/InterpreterSelectQueryAnalyzer.cpp

@@ -158,6 +158,7 @@ static QueryTreeNodePtr buildQueryTreeAndRunPasses(const ASTPtr & query,
     /// We should not apply any query tree level optimizations on shards
     /// because it can lead to a changed header.
     if (select_query_options.ignore_ast_optimizations
+        || select_query_options.is_create_view
         || context->getClientInfo().query_kind == ClientInfo::QueryKind::SECONDARY_QUERY)
         query_tree_pass_manager.runOnlyResolve(query_tree);
     else

src/Interpreters/SelectQueryOptions.h

@@ -45,6 +45,7 @@ struct SelectQueryOptions
     bool is_create_parameterized_view = false;
     /// Bypass setting constraints for some internal queries such as projection ASTs.
     bool ignore_setting_constraints = false;
+    bool is_create_view = false; /// this select is a part of CREATE [MATERIALIZED] VIEW query
 
     /// Bypass access check for select query.
     /// This allows to skip double access check in some specific cases (e.g. insert into table with materialized view)
@@ -87,6 +88,12 @@ struct SelectQueryOptions
         return out;
     }
 
+    SelectQueryOptions & createView(bool value = true)
+    {
+        is_create_view = value;
+        return *this;
+    }
+
     SelectQueryOptions createParameterizedView() const
     {
         SelectQueryOptions out = *this;

tests/queries/0_stateless/02006_test_positional_arguments_on_cluster.reference

@@ -1,2 +1,4 @@
 d	Date					
 f	UInt64					
+a	String					
+total	UInt64					

tests/queries/0_stateless/02006_test_positional_arguments_on_cluster.sql

@@ -17,3 +17,40 @@ DESC t02006;
 
 DROP TABLE IF EXISTS t02006 on cluster test_shard_localhost format Null;
 DROP TABLE IF EXISTS m02006 on cluster test_shard_localhost format Null;
+DROP TABLE IF EXISTS tt02006 on cluster test_shard_localhost format Null;
+
+SET enable_analyzer=1;
+
+CREATE TABLE t02006 ON CLUSTER test_shard_localhost
+(
+    `a` String,
+    `b` UInt32
+)
+ENGINE = ReplicatedMergeTree
+PRIMARY KEY a
+ORDER BY a
+format Null;
+
+CREATE TABLE tt02006 ON CLUSTER test_shard_localhost
+(
+    `a` String,
+    `total` SimpleAggregateFunction(sum, UInt64)
+)
+ENGINE = ReplicatedAggregatingMergeTree
+ORDER BY a
+format Null;
+
+CREATE MATERIALIZED VIEW m02006 ON CLUSTER test_shard_localhost TO tt02006
+AS SELECT
+    a,
+    sum(b) AS total
+FROM  t02006
+GROUP BY 1
+ORDER BY 1 ASC
+format Null;
+
+DESC m02006;
+
+DROP TABLE IF EXISTS t02006 on cluster test_shard_localhost format Null;
+DROP TABLE IF EXISTS m02006 on cluster test_shard_localhost format Null;
+DROP TABLE IF EXISTS tt02006 on cluster test_shard_localhost format Null;