Merge pull request ClickHouse#78618 from ClickHouse/fix-analyzer-join-using-alias

Fix analyzer: add proper exception when JOIN ... USING involves ALIAS column

Author: yakov-olkhovskiy

src/Planner/PlannerJoinTree.cpp

@@ -1837,19 +1837,27 @@ JoinTreeQueryPlan buildQueryPlanForJoinNodeLegacy(
             auto & inner_columns_list = join_node_using_column_node.getExpressionOrThrow()->as<ListNode &>();
 
             auto & left_inner_column_node = inner_columns_list.getNodes().at(0);
-            auto & left_inner_column = left_inner_column_node->as<ColumnNode &>();
+            auto * left_inner_column = left_inner_column_node->as<ColumnNode>();
+            if (!left_inner_column)
+                throw Exception(ErrorCodes::BAD_ARGUMENTS,
+                    "JOIN USING clause expected column identifier. Actual {}",
+                    left_inner_column_node->formatASTForErrorMessage());
 
             auto & right_inner_column_node = inner_columns_list.getNodes().at(1);
-            auto & right_inner_column = right_inner_column_node->as<ColumnNode &>();
+            auto * right_inner_column = right_inner_column_node->as<ColumnNode>();
+            if (!right_inner_column)
+                throw Exception(ErrorCodes::BAD_ARGUMENTS,
+                    "JOIN USING clause expected column identifier. Actual {}",
+                    right_inner_column_node->formatASTForErrorMessage());
 
             const auto & join_node_using_column_node_type = join_node_using_column_node.getColumnType();
-            if (!left_inner_column.getColumnType()->equals(*join_node_using_column_node_type))
+            if (!left_inner_column->getColumnType()->equals(*join_node_using_column_node_type))
             {
                 const auto & left_inner_column_identifier = planner_context->getColumnNodeIdentifierOrThrow(left_inner_column_node);
                 left_plan_column_name_to_cast_type.emplace(left_inner_column_identifier, join_node_using_column_node_type);
             }
 
-            if (!right_inner_column.getColumnType()->equals(*join_node_using_column_node_type))
+            if (!right_inner_column->getColumnType()->equals(*join_node_using_column_node_type))
             {
                 const auto & right_inner_column_identifier = planner_context->getColumnNodeIdentifierOrThrow(right_inner_column_node);
                 right_plan_column_name_to_cast_type.emplace(right_inner_column_identifier, join_node_using_column_node_type);

src/Planner/PlannerJoinsLogical.cpp

@@ -59,6 +59,7 @@ namespace ErrorCodes
     extern const int LOGICAL_ERROR;
     extern const int NOT_IMPLEMENTED;
     extern const int INVALID_JOIN_ON_EXPRESSION;
+    extern const int BAD_ARGUMENTS;
 }
 
 namespace Setting
@@ -104,11 +105,25 @@ struct JoinInfoBuildContext
             {
                 auto & column_node = join_using_node->as<ColumnNode &>();
                 auto & column_node_sources = column_node.getExpressionOrThrow()->as<ListNode &>();
+
+                const auto column_left = column_node_sources.getNodes().at(0);
+                if (!column_left->as<ColumnNode>())
+                    throw Exception(ErrorCodes::BAD_ARGUMENTS,
+                        "JOIN USING clause expected column identifier. Actual {}",
+                        column_left->formatASTForErrorMessage());
+
                 changed_types.emplace(
-                    planner_context_->getColumnNodeIdentifierOrThrow(column_node_sources.getNodes().at(0)),
+                    planner_context_->getColumnNodeIdentifierOrThrow(column_left),
                     column_node.getColumnType());
+
+                const auto column_right = column_node_sources.getNodes().at(1);
+                if (!column_right->as<ColumnNode>())
+                    throw Exception(ErrorCodes::BAD_ARGUMENTS,
+                        "JOIN USING clause expected column identifier. Actual {}",
+                        column_right->formatASTForErrorMessage());
+
                 changed_types.emplace(
-                    planner_context_->getColumnNodeIdentifierOrThrow(column_node_sources.getNodes().at(1)),
+                    planner_context_->getColumnNodeIdentifierOrThrow(column_right),
                     column_node.getColumnType());
             }
         }

tests/queries/0_stateless/03402_join_using_alias.reference

@@ -0,0 +1,10 @@
+set enable_analyzer=1;
+
+DROP TABLE IF EXISTS t0;
+
+CREATE TABLE t0 (c0 Int, c1 Int ALIAS 1) ENGINE = Memory;
+SELECT c0 FROM remote('localhost', currentDatabase(), 't0') tx JOIN t0 USING (c1); -- { serverError BAD_ARGUMENTS }
+
+SELECT c0 FROM remote('localhost', currentDatabase(), 't0') tx JOIN t0 USING (c1) SETTINGS query_plan_use_new_logical_join_step=0; -- { serverError BAD_ARGUMENTS }
+
+DROP TABLE IF EXISTS t0;