Revert "addressing fuzzer failure and updating test outputs"

george-larionov · george-larionov · commit 9043f451db97 · 2025-05-21T14:11:50.000-04:00
This reverts commit a1cd648.
diff --git a/src/Functions/bech32.cpp b/src/Functions/bech32.cpp
@@ -434,8 +434,7 @@ class DecodeFromBech32Representation : public IFunction
 
             bech32_data data_8bit;
             if (dec.encoding == bech32::Encoding::INVALID
-                || !convertbits<5, 8, false>(data_8bit, bech32_data(dec.data.begin(), dec.data.end()))
-                || data_8bit.empty())
+                || !convertbits<5, 8, false>(data_8bit, bech32_data(dec.data.begin(), dec.data.end())))
             {
                 finalizeRow(hrp_offsets, hrp_pos, hrp_begin, i);
                 finalizeRow(data_offsets, data_pos, data_begin, i);
diff --git a/tests/queries/0_stateless/02415_all_new_functions_must_be_documented.reference b/tests/queries/0_stateless/02415_all_new_functions_must_be_documented.reference
@@ -109,8 +109,6 @@ bar
 base58Decode
 base58Encode
 basename
-bech32Decode
-bech32Encode
 bin
 bitAnd
 bitCount
diff --git a/tests/queries/0_stateless/02415_all_new_functions_must_have_version_information.reference b/tests/queries/0_stateless/02415_all_new_functions_must_have_version_information.reference
@@ -136,8 +136,6 @@ base32Encode
 base58Decode
 base58Encode
 basename
-bech32Decode
-bech32Encode
 bin
 bitAnd
 bitCount

Original file line number	Diff line number	Diff line change
`@@ -434,8 +434,7 @@ class DecodeFromBech32Representation : public IFunction`
`434`	`434`
`435`	`435`	`bech32_data data_8bit;`
`436`	`436`	`if (dec.encoding == bech32::Encoding::INVALID`
`437`		`- \|\| !convertbits<5, 8, false>(data_8bit, bech32_data(dec.data.begin(), dec.data.end()))`
`438`		`- \|\| data_8bit.empty())`
	`437`	`+ \|\| !convertbits<5, 8, false>(data_8bit, bech32_data(dec.data.begin(), dec.data.end())))`
`439`	`438`	`{`
`440`	`439`	`finalizeRow(hrp_offsets, hrp_pos, hrp_begin, i);`
`441`	`440`	`finalizeRow(data_offsets, data_pos, data_begin, i);`