Merge branch 'master' into add-test-58987

Author: alexey-milovidov

base/base/Decimal.h

@@ -10,6 +10,7 @@ namespace DB
 {
 template <class> struct Decimal;
 class DateTime64;
+class Time64;
 
 #define FOR_EACH_UNDERLYING_DECIMAL_TYPE(M) \
     M(Int32) \
@@ -142,6 +143,16 @@ class DateTime64 : public Decimal64
 
     constexpr DateTime64(const Base & v): Base(v) {} // NOLINT(google-explicit-constructor)
 };
+
+class Time64 : public Decimal64
+{
+public:
+    using Base = Decimal64;
+    using Base::Base;
+    using NativeType = Base::NativeType;
+
+    constexpr Time64(const Base & v): Base(v) {} // NOLINT(google-explicit-constructor)
+};
 }
 
 constexpr UInt64 max_uint_mask = std::numeric_limits<UInt64>::max();
@@ -173,6 +184,15 @@ namespace std
         }
     };
 
+    template <>
+    struct hash<DB::Time64>
+    {
+        size_t operator()(const DB::Time64 & x) const
+        {
+            return std::hash<DB::Time64::NativeType>()(x);
+        }
+    };
+
     template <>
     struct hash<DB::Decimal256>
     {

base/base/Decimal_fwd.h

@@ -27,14 +27,16 @@ using Decimal128 = Decimal<Int128>;
 using Decimal256 = Decimal<Int256>;
 
 class DateTime64;
+class Time64;
 
 template <class T>
 concept is_decimal =
     std::is_same_v<T, Decimal32>
     || std::is_same_v<T, Decimal64>
     || std::is_same_v<T, Decimal128>
     || std::is_same_v<T, Decimal256>
-    || std::is_same_v<T, DateTime64>;
+    || std::is_same_v<T, DateTime64>
+    || std::is_same_v<T, Time64>;
 
 template <class T>
 concept is_over_big_int =

base/base/TypeName.h

@@ -44,6 +44,7 @@ TN_MAP(Decimal64)
 TN_MAP(Decimal128)
 TN_MAP(Decimal256)
 TN_MAP(DateTime64)
+TN_MAP(Time64)
 TN_MAP(Array)
 TN_MAP(Tuple)
 TN_MAP(Map)

base/base/extended_types.h

@@ -74,6 +74,7 @@ template <typename T> concept is_floating_point =
     M(DataTypeDate) \
     M(DataTypeDate32) \
     M(DataTypeDateTime) \
+    M(DataTypeTime) \
     M(DataTypeInt8) \
     M(DataTypeUInt8) \
     M(DataTypeInt16) \
@@ -94,6 +95,7 @@ template <typename T> concept is_floating_point =
     M(DataTypeDate, X) \
     M(DataTypeDate32, X) \
     M(DataTypeDateTime, X) \
+    M(DataTypeTime, X) \
     M(DataTypeInt8, X) \
     M(DataTypeUInt8, X) \
     M(DataTypeInt16, X) \

ci/jobs/docs_job.py

@@ -77,7 +77,6 @@
         Result.from_commands_run(
             name=testname,
             command=[
-                "yarn build-api-doc",
                 "yarn build-swagger",
                 "export DOCUSAURUS_IGNORE_SSG_WARNINGS=true && yarn build-docs",
             ],

ci/jobs/scripts/check_style/aspell-ignore/en/aspell-dict.txt

@@ -1251,6 +1251,7 @@ aggthrow
 aiochclient
 alloc
 allocator
+allowlist
 alphaTokens
 amplab
 analysisOfVariance
@@ -1687,6 +1688,7 @@ denormalize
 denormalized
 denormalizing
 denormals
+denylist
 dequeued
 dequeues
 dereference
@@ -3043,6 +3045,7 @@ toStartOfYear
 toString
 toStringCutToZero
 toTime
+toTimeWithFixedDate
 toTimeZone
 toType
 toTypeName

ci/jobs/scripts/functional_tests_results.py

@@ -26,10 +26,6 @@
 #         out = csv.writer(f, delimiter="\t")
 #         out.writerow(status)
 
-BROKEN_TESTS_ANALYZER_TECH_DEBT = [
-    "01624_soft_constraints",
-]
-
 
 class FTResultsProcessor:
     @dataclasses.dataclass
@@ -50,7 +46,6 @@ def __init__(self, wd):
         self.tests_output_file = f"{wd}/test_result.txt"
         # self.test_results_parsed_file = f"{wd}/test_result.tsv"
         # self.status_file = f"{wd}/check_status.tsv"
-        self.broken_tests = BROKEN_TESTS_ANALYZER_TECH_DEBT
 
     def _process_test_output(self):
         total = 0
@@ -97,41 +92,20 @@ def _process_test_output(self):
 
                     total += 1
                     if TIMEOUT_SIGN in line:
-                        if test_name in self.broken_tests:
-                            success += 1
-                            test_results.append((test_name, "BROKEN", test_time, []))
-                        else:
-                            failed += 1
-                            test_results.append((test_name, "Timeout", test_time, []))
+                        failed += 1
+                        test_results.append((test_name, "Timeout", test_time, []))
                     elif FAIL_SIGN in line:
-                        if test_name in self.broken_tests:
-                            success += 1
-                            test_results.append((test_name, "BROKEN", test_time, []))
-                        else:
-                            failed += 1
-                            test_results.append((test_name, "FAIL", test_time, []))
+                        failed += 1
+                        test_results.append((test_name, "FAIL", test_time, []))
                     elif UNKNOWN_SIGN in line:
                         unknown += 1
                         test_results.append((test_name, "FAIL", test_time, []))
                     elif SKIPPED_SIGN in line:
                         skipped += 1
                         test_results.append((test_name, "SKIPPED", test_time, []))
                     else:
-                        if OK_SIGN in line and test_name in self.broken_tests:
-                            skipped += 1
-                            test_results.append(
-                                (
-                                    test_name,
-                                    "NOT_FAILED",
-                                    test_time,
-                                    [
-                                        "This test passed. Update analyzer_tech_debt.txt.\n"
-                                    ],
-                                )
-                            )
-                        else:
-                            success += int(OK_SIGN in line)
-                            test_results.append((test_name, "OK", test_time, []))
+                        success += int(OK_SIGN in line)
+                        test_results.append((test_name, "OK", test_time, []))
                     test_end = False
                 elif (
                     len(test_results) > 0

ci/jobs/scripts/workflow_hooks/trusted.py

@@ -7,10 +7,10 @@
     e.lower()
     for e in [
         "amosbird",
+        "azat",
         "den-crane",  # Documentation contributor
         "taiyang-li",
         "ucasFL",  # Amos Bird's friend
-        "tonickkozlov",  # Cloudflare
         "canhld94",
     ]
 }

docker/test/fuzzer/run-fuzzer.sh

@@ -379,8 +379,11 @@ EOF
     elif [ "$server_died" == 1 ]
     then
         # The server has died.
-        if ! rg --text -o 'Received signal.*|Logical error.*|Assertion.*failed|Failed assertion.*|.*runtime error: .*|.*is located.*|(SUMMARY|ERROR): [a-zA-Z]+Sanitizer:.*|.*_LIBCPP_ASSERT.*|.*Child process was terminated by signal 9.*' server.log > description.txt
+        if rg --text -o 'Received signal.*|Logical error.*|Assertion.*failed|Failed assertion.*|.*runtime error: .*|.*is located.*|(SUMMARY|ERROR): [a-zA-Z]+Sanitizer:.*|.*_LIBCPP_ASSERT.*|.*Child process was terminated by signal 9.*' server.log > description.txt
         then
+            # Save the stack trace of the server to the description file and preserve in raw text output.
+            rg --text '\s<Fatal>\s' server.log >> description.txt || :
+        else
             echo "Lost connection to server. See the logs." > description.txt
         fi
 

docs/en/engines/table-engines/mergetree-family/annindexes.md

@@ -394,7 +394,7 @@ returns
    └────┴─────────┘
 ```
 
-# References {#references}
+## References {#references}
 
 Blogs:
 - [Vector Search with ClickHouse - Part 1](https://clickhouse.com/blog/vector-search-clickhouse-p1)