Skip to content

Commit 91c71ca

Browse files
committed
rename setting from output to input
1 parent 6d97fa8 commit 91c71ca

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

src/Core/FormatFactorySettings.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1316,7 +1316,7 @@ Set the quoting style for identifiers in SHOW CREATE query
13161316
Limits the size of the blocks formed during data parsing in input formats in bytes. Used in row based input formats when block is formed on ClickHouse side.
13171317
0 means no limit in bytes.
13181318
)", 0) \
1319-
DECLARE(Bool, output_format_parquet_allow_geoparquet_parser, true, R"(
1319+
DECLARE(Bool, input_format_parquet_allow_geoparquet_parser, true, R"(
13201320
Use geo column parser to convert Array(UInt8) into Point/Linestring/Polygon/MultiLineString/MultiPolygon types
13211321
)", 0) \
13221322

src/Core/SettingsChangesHistory.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ const VersionToSettingsChangesMap & getSettingsChangesHistory()
9898
{"allow_experimental_database_hms_catalog", false, false, "Allow experimental database engine DataLakeCatalog with catalog_type = 'hive'"},
9999
{"compile_expressions", false, true, "We believe that the LLVM infrastructure behind the JIT compiler is stable enough to enable this setting by default."},
100100
{"use_legacy_to_time", false, false, "New setting. Allows for user to use the old function logic for toTime, which works as toTimeWithFixedDate."},
101-
{"output_format_parquet_allow_geoparquet_parser", false, true, "A new setting to use geo columns in parquet file"},
101+
{"input_format_parquet_allow_geoparquet_parser", false, true, "A new setting to use geo columns in parquet file"},
102102
});
103103
addSettingsChanges(settings_changes_history, "25.4",
104104
{

src/Formats/FormatFactory.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ FormatSettings getFormatSettings(const ContextPtr & context, const Settings & se
214214
format_settings.parquet.bloom_filter_flush_threshold_bytes = settings[Setting::output_format_parquet_bloom_filter_flush_threshold_bytes];
215215
format_settings.parquet.local_read_min_bytes_for_seek = settings[Setting::input_format_parquet_local_file_min_bytes_for_seek];
216216
format_settings.parquet.enable_row_group_prefetch = settings[Setting::input_format_parquet_enable_row_group_prefetch];
217-
format_settings.parquet.allow_geoparquet_parser = settings[Setting::output_format_parquet_allow_geoparquet_parser];
217+
format_settings.parquet.allow_geoparquet_parser = settings[Setting::input_format_parquet_allow_geoparquet_parser];
218218
format_settings.pretty.charset = settings[Setting::output_format_pretty_grid_charset].toString() == "ASCII" ? FormatSettings::Pretty::Charset::ASCII : FormatSettings::Pretty::Charset::UTF8;
219219
format_settings.pretty.color = settings[Setting::output_format_pretty_color].valueOr(2);
220220
format_settings.pretty.glue_chunks = settings[Setting::output_format_pretty_glue_chunks].valueOr(2);

tests/queries/0_stateless/03445_geoparquet.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ $CLICKHOUSE_LOCAL -q "select * from file('$CURDIR/data_parquet/03445_geoparquet_
1010
$CLICKHOUSE_LOCAL -q "select * from file('$CURDIR/data_parquet/03445_geoparquet_null_point.parquet', Parquet)"
1111
$CLICKHOUSE_LOCAL -q "select * from file('$CURDIR/data_parquet/03445_geoparquet_null_linestring.parquet', Parquet)"
1212
$CLICKHOUSE_LOCAL -q "select * from file('$CURDIR/data_parquet/03445_geoparquet_null_polygon.parquet', Parquet)"
13-
$CLICKHOUSE_LOCAL -q "select * from file('$CURDIR/data_parquet/03445_geoparquet_wkb.parquet', Parquet) SETTINGS output_format_parquet_allow_geoparquet_parser=false;"
13+
$CLICKHOUSE_LOCAL -q "select * from file('$CURDIR/data_parquet/03445_geoparquet_wkb.parquet', Parquet) SETTINGS input_format_parquet_allow_geoparquet_parser=false;"

0 commit comments

Comments
 (0)