Merge pull request ClickHouse#79574 from ClickHouse/hanfei/fix-poco-json-datarace

fix data race in poco::JSON::stringify

Author: hanfei1991

base/poco/JSON/include/Poco/JSON/Array.h

@@ -208,7 +208,7 @@ namespace JSON
         //  The reason we have this flag here (rather than as argument to stringify())
         //  is because Array can be returned stringified from a Dynamic::Var:toString(),
         //  so it must know whether to escape unicode or not.
-        bool _escapeUnicode;
+        std::atomic<bool> _escapeUnicode;
     };
 
 

base/poco/JSON/include/Poco/JSON/Object.h

@@ -18,6 +18,7 @@
 #define JSON_Object_INCLUDED
 
 
+#include <atomic>
 #include <deque>
 #include <iostream>
 #include <map>
@@ -292,7 +293,7 @@ namespace JSON
         //  The reason for this flag (rather than as argument to stringify()) is
         //  because Object can be returned stringified from Dynamic::Var::toString(),
         //  so it must know whether to escape unicode or not.
-        bool _escapeUnicode;
+        std::atomic<bool> _escapeUnicode;
         mutable StructPtr _pStruct;
         mutable bool _modified;
     };

base/poco/JSON/src/Object.cpp

@@ -33,7 +33,7 @@ Object::Object(int options):
 
 Object::Object(const Object& other) : _values(other._values),
 	_preserveInsOrder(other._preserveInsOrder),
-	_escapeUnicode(other._escapeUnicode),
+	_escapeUnicode(other._escapeUnicode.load()),
 	_pStruct(!other._modified ? other._pStruct : 0),
 	_modified(other._modified)
 {
@@ -48,7 +48,7 @@ Object::Object(Object&& other) :
 	_values(std::move(other._values)),
 	_keys(std::move(other._keys)),
 	_preserveInsOrder(other._preserveInsOrder),
-	_escapeUnicode(other._escapeUnicode),
+	_escapeUnicode(other._escapeUnicode.load()),
 	_pStruct(!other._modified ? other._pStruct : 0),
 	_modified(other._modified)
 {
@@ -63,7 +63,7 @@ Object &Object::operator= (Object &&other)
 		_values = other._values;
 		_preserveInsOrder = other._preserveInsOrder;
 		syncKeys(other._keys);
-		_escapeUnicode = other._escapeUnicode;
+		_escapeUnicode = other._escapeUnicode.load();
 		_pStruct = !other._modified ? other._pStruct : 0;
 		_modified = other._modified;
 		other.clear();
@@ -87,7 +87,7 @@ Object &Object::operator= (const Object &other)
 		_values = other._values;
 		_keys = other._keys;
 		_preserveInsOrder = other._preserveInsOrder;
-		_escapeUnicode = other._escapeUnicode;
+		_escapeUnicode = other._escapeUnicode.load();
 		_pStruct = !other._modified ? other._pStruct : 0;
 		_modified = other._modified;
 	}