handling mixed const and column data

Author: george-larionov

src/Functions/FunctionsBech32Representation.cpp

@@ -159,8 +159,8 @@ class EncodeToBech32Representation : public IFunction
     ColumnPtr executeImpl(const ColumnsWithTypeAndName & arguments, const DataTypePtr &, size_t input_rows_count) const override
     {
         bool have_witver = arguments.size() == 3;
-        const ColumnPtr & col0 = arguments[0].column;
-        const ColumnPtr & col1 = arguments[1].column;
+        ColumnPtr col0 = arguments[0].column->convertToFullColumnIfConst();
+        ColumnPtr col1 = arguments[1].column->convertToFullColumnIfConst();
         ColumnPtr col2;
         if (have_witver)
             col2 = arguments[2].column;

tests/queries/0_stateless/03512_bech32_enc_dec.reference

@@ -13,6 +13,9 @@ bc1w508d6qejxtdg4y5r3zarvary0c5xw7k8zcwmq
 bc1w508d6qejxtdg4y5r3zarvary0c5xw7kj7gz7z
 1
 bc	751E76E8199196D454941C45D1B3A323F1433BD6
+bc1v6r3z2nw4k6d3rffc7j9mftwluxz8v8pfe6h6syw7j5lwr
+bc1v6r3z2nw4k6d3rffc7j9mftwluxz8v8pfe6h6syw7j5lwr
+bc1v6r3z2nw4k6d3rffc7j9mftwluxz8v8pfe6h6syw7j5lwr
 bc1v6r3z2nw4k6d3rffc7j9mftwluxz8v8pfe6h6syw7j5lwr	bc1v6r3z2nw4k6d3rffc7j9mftwluxz8v8pfe6h6sywtwyntp	1	1	1
 tb137xd6smyhd7u5ywyjapa5tzt2srzlgpc3wleysrcwmcmel	tb137xd6smyhd7u5ywyjapa5tzt2srzlgpc3wleysrcwmcmel	1	1	1
 bc12zuq63wvya0nd66lktpz4ylk5n5rh2fcpe2uvlm2cdq5mu	bc12zuq63wvya0nd66lktpz4ylk5n5rh2fcpe2uvlm2cdq5mu	1	1	1

tests/queries/0_stateless/03512_bech32_enc_dec.sql

@@ -50,6 +50,15 @@ INSERT INTO hex_data VALUES
 ('tb', 'b103a1937c6e2fb9de707a4be02d5d39e217b4bca7ce3c9c12', 0),
 ('bcrt', '95eb334ff82ef8ad76151c29094abdae6c9e8bb8244523e347', 2);
 
+-- test const hrp with column data
+SELECT bech32Encode('bc', unhex(data)) FROM hex_data limit 1;
+
+-- test const data with column hrp
+SELECT bech32Encode(hrp, unhex('6687112a6eadb4d88d29c7a45da56eff0c23b0e14e757d408e')) FROM hex_data limit 1;
+
+-- test column hrp and data with const witver
+SELECT bech32Encode(hrp, unhex(data), 1) FROM hex_data limit 1;
+
 -- for encoding, if using a FixedString column for the data it is crucial that there is no padding
 -- since the input is binary, there is no way to check for it
 CREATE TABLE bech32_test