Skip to content

Commit b25d4ef

Browse files
AlgunenanoAlgunenano
authored
Merge branch 'master' into alex-dc
2 parents a3f0e87 + 1201bb1 commit b25d4ef

File tree

545 files changed

+10343
-5962
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

545 files changed

+10343
-5962
lines changed

‎.github/ISSUE_TEMPLATE/30_unexpected-behaviour.yaml‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,12 @@ body:
1515
- type: textarea
1616
attributes:
1717
label: Describe the unexpected behaviour
18-
description: A clear and concise description of what works not as it is supposed to.
18+
description: A clear and concise description of what doesn't work as it is supposed to.
19+
validations:
20+
required: true
21+
- type: textarea
22+
attributes:
23+
label: Which ClickHouse versions are affected?
1924
validations:
2025
required: true
2126
- type: textarea
@@ -26,7 +31,7 @@ body:
2631
* Which interface to use, if matters
2732
* Non-default settings, if any
2833
* `CREATE TABLE` statements for all tables involved
29-
* Sample data for all these tables, use [clickhouse-obfuscator](https://github.com/ClickHouse/ClickHouse/blob/master/programs/obfuscator/Obfuscator.cpp#L42-L80) if necessary
34+
* Sample data for all these tables, use [clickhouse-obfuscator](https://github.com/ClickHouse/ClickHouse/blob/c81bec37a58757be1e2b1ac6f20a62b3f14a31f1/programs/obfuscator/Obfuscator.cpp#L55-L95) if necessary
3035
* Queries to run that lead to unexpected result
3136
validations:
3237
required: true

‎.github/ISSUE_TEMPLATE/35_incomplete_implementation.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ body:
2626
* Which interface to use, if matters
2727
* Non-default settings, if any
2828
* `CREATE TABLE` statements for all tables involved
29-
* Sample data for all these tables, use [clickhouse-obfuscator](https://github.com/ClickHouse/ClickHouse/blob/master/programs/obfuscator/Obfuscator.cpp#L42-L80) if necessary
29+
* Sample data for all these tables, use [clickhouse-obfuscator](https://github.com/ClickHouse/ClickHouse/blob/c81bec37a58757be1e2b1ac6f20a62b3f14a31f1/programs/obfuscator/Obfuscator.cpp#L55-L95) if necessary
3030
* Queries to run that lead to unexpected result
3131
validations:
3232
required: true

‎.github/ISSUE_TEMPLATE/45_usability-issue.yaml‎

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Usability issue
1+
name: Usability improvement request
22
description: Report something can be made more convenient to use
33
labels: ["usability"]
44
body:
@@ -14,28 +14,26 @@ body:
1414
required: false
1515
- type: textarea
1616
attributes:
17-
label: Describe the unexpected behaviour
18-
description: A clear and concise description of what works not as it is supposed to.
17+
label: Describe the improvement
18+
description: A clear and concise description of what you want to happen
19+
validations:
20+
required: true
21+
- type: textarea
22+
attributes:
23+
label: Which ClickHouse versions are affected?
1924
validations:
2025
required: true
2126
- type: textarea
2227
attributes:
2328
label: How to reproduce
2429
description: |
25-
* Which ClickHouse server version to use
2630
* Which interface to use, if matters
2731
* Non-default settings, if any
2832
* `CREATE TABLE` statements for all tables involved
29-
* Sample data for all these tables, use [clickhouse-obfuscator](https://github.com/ClickHouse/ClickHouse/blob/master/programs/obfuscator/Obfuscator.cpp#L42-L80) if necessary
33+
* Sample data for all these tables, use [clickhouse-obfuscator](https://github.com/ClickHouse/ClickHouse/blob/c81bec37a58757be1e2b1ac6f20a62b3f14a31f1/programs/obfuscator/Obfuscator.cpp#L55-L95) if necessary
3034
* Queries to run that lead to unexpected result
3135
validations:
3236
required: true
33-
- type: textarea
34-
attributes:
35-
label: Expected behavior
36-
description: A clear and concise description of what you expected to happen.
37-
validations:
38-
required: false
3937
- type: textarea
4038
attributes:
4139
label: Error message and/or stacktrace

‎.github/ISSUE_TEMPLATE/50_build-issue.yaml‎

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,33 +12,39 @@ body:
1212
description: Put your company name or project description here.
1313
validations:
1414
required: false
15+
- type: textarea
16+
attributes:
17+
label: Describe the problem
18+
description: A clear and concise description of what doesn't work as it is supposed to.
19+
validations:
20+
required: true
1521
- type: textarea
1622
attributes:
1723
label: Operating system
1824
description: OS kind or distribution, specific version/release, non-standard kernel if any. If you are trying to build inside virtual machine, please mention it too.
1925
validations:
20-
required: true
26+
required: false
2127
- type: textarea
2228
attributes:
2329
label: CMake version
2430
description: The output of `cmake --version`.
2531
validations:
26-
required: true
32+
required: false
2733
- type: textarea
2834
attributes:
2935
label: Ninja version
3036
description: The output of `ninja --version`.
3137
validations:
32-
required: true
38+
required: false
3339
- type: textarea
3440
attributes:
3541
label: Compiler name and version
3642
description: We recommend to use clang. The version can be obtained via `clang --version`.
3743
validations:
38-
required: true
44+
required: false
3945
- type: textarea
4046
attributes:
41-
label: Full cmake and/or ninja output
42-
description: Please include everything!
47+
label: Full cmake and/or ninja output with the error
48+
description: Please include everything (use https://pastila.nl/ for large output)!
4349
validations:
4450
required: true

‎.github/ISSUE_TEMPLATE/70_performance-issue.yaml‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,19 @@ body:
1818
description: What exactly works slower than expected?
1919
validations:
2020
required: true
21+
- type: textarea
22+
attributes:
23+
label: Which ClickHouse versions are affected?
24+
validations:
25+
required: true
2126
- type: textarea
2227
attributes:
2328
label: How to reproduce
2429
description: |
25-
* Which ClickHouse server version to use
2630
* Which interface to use, if matters
2731
* Non-default settings, if any
2832
* `CREATE TABLE` statements for all tables involved
29-
* Sample data for all these tables, use [clickhouse-obfuscator](https://github.com/ClickHouse/ClickHouse/blob/master/programs/obfuscator/Obfuscator.cpp#L42-L80) if necessary
33+
* Sample data for all these tables, use [clickhouse-obfuscator](https://github.com/ClickHouse/ClickHouse/blob/c81bec37a58757be1e2b1ac6f20a62b3f14a31f1/programs/obfuscator/Obfuscator.cpp#L55-L95) if necessary
3034
* Queries to run that lead to unexpected result
3135
validations:
3236
required: true

‎.github/ISSUE_TEMPLATE/80_backward-compatibility.yaml‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,19 @@ body:
1818
description: A clear and concise description of what works not as it is supposed to.
1919
validations:
2020
required: true
21+
- type: textarea
22+
attributes:
23+
label: Which ClickHouse versions are affected?
24+
validations:
25+
required: true
2126
- type: textarea
2227
attributes:
2328
label: How to reproduce
2429
description: |
25-
* Which ClickHouse server version to use
2630
* Which interface to use, if matters
2731
* Non-default settings, if any
2832
* `CREATE TABLE` statements for all tables involved
29-
* Sample data for all these tables, use [clickhouse-obfuscator](https://github.com/ClickHouse/ClickHouse/blob/master/programs/obfuscator/Obfuscator.cpp#L42-L80) if necessary
33+
* Sample data for all these tables, use [clickhouse-obfuscator](https://github.com/ClickHouse/ClickHouse/blob/c81bec37a58757be1e2b1ac6f20a62b3f14a31f1/programs/obfuscator/Obfuscator.cpp#L55-L95) if necessary
3034
* Queries to run that lead to unexpected result
3135
validations:
3236
required: true

‎.github/ISSUE_TEMPLATE/85_bug-report.yaml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,9 @@ body:
3838
> Change "enabled" to true in "send_crash_reports" section in `config.xml`:
3939
```xml
4040
<send_crash_reports>
41-
<!-- Changing <enabled> to true allows sending crash reports to -->
42-
<!-- the ClickHouse core developers team via Sentry https://sentry.io -->
43-
<enabled>false</enabled>
41+
<!-- Changing <enabled> to true allows sending crash reports to -->
42+
<!-- the ClickHouse core developers team. -->
43+
<enabled>true</enabled>
4444
</send_crash_reports>
4545
```
4646
-----
@@ -52,7 +52,7 @@ body:
5252
* Which interface to use, if matters
5353
* Non-default settings, if any
5454
* `CREATE TABLE` statements for all tables involved
55-
* Sample data for all these tables, use [clickhouse-obfuscator](https://github.com/ClickHouse/ClickHouse/blob/master/programs/obfuscator/Obfuscator.cpp#L42-L80) if necessary
55+
* Sample data for all these tables, use [clickhouse-obfuscator](https://github.com/ClickHouse/ClickHouse/blob/c81bec37a58757be1e2b1ac6f20a62b3f14a31f1/programs/obfuscator/Obfuscator.cpp#L55-L95) if necessary
5656
* Queries to run that lead to unexpected result
5757
validations:
5858
required: true

‎.gitmodules‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -137,9 +137,6 @@
137137
[submodule "contrib/fmtlib"]
138138
path = contrib/fmtlib
139139
url = https://github.com/fmtlib/fmt
140-
[submodule "contrib/sentry-native"]
141-
path = contrib/sentry-native
142-
url = https://github.com/ClickHouse/sentry-native
143140
[submodule "contrib/krb5"]
144141
path = contrib/krb5
145142
url = https://github.com/ClickHouse/krb5

0 commit comments

Comments
 (0)