renamed last_error_query_id in system.errors

Author: Dolso

src/Storages/System/StorageSystemErrors.cpp

@@ -29,7 +29,7 @@ ColumnsDescription StorageSystemErrors::getColumnsDescription()
         { "last_error_message",      std::make_shared<DataTypeString>(), "Message for the last error."},
         { "last_error_trace",        std::make_shared<DataTypeArray>(std::make_shared<DataTypeUInt64>()), "A stack trace that represents a list of physical addresses where the called methods are stored."},
         { "remote",                  std::make_shared<DataTypeUInt8>(), "Remote exception (i.e. received during one of the distributed queries)."},
-        { "last_error_query_id",     std::make_shared<DataTypeString>(), "Id of a query that caused the last error (if available)." },
+        { "query_id",                std::make_shared<DataTypeString>(), "Id of a query that caused the last error (if available)." },
         { "last_error_symbols",      symbolized_type, "Contains demangled symbol names, corresponding to the `trace`." },
         { "last_error_lines",        symbolized_type, "Contains strings with file names with line numbers, corresponding to the `trace`." },
     };

tests/queries/0_stateless/02117_show_create_table_system.reference

@@ -265,7 +265,7 @@ CREATE TABLE system.errors
     `last_error_message` String,
     `last_error_trace` Array(UInt64),
     `remote` UInt8,
-    `last_error_query_id` String,
+    `query_id` String,
     `last_error_symbols` Array(LowCardinality(String)),
     `last_error_lines` Array(LowCardinality(String))
 )

tests/queries/0_stateless/03361_system_errors_query_id.sh

@@ -10,7 +10,7 @@ $CLICKHOUSE_CLIENT --query_id="$query_id" -q "select query_id" &>/dev/null
 
 retry=0
 max_retries=30
-while [[ $($CLICKHOUSE_CLIENT -q "SELECT count(*) FROM system.errors WHERE last_error_query_id = '$query_id' and code = 47") -lt 1 ]]; do
+while [[ $($CLICKHOUSE_CLIENT -q "SELECT count(*) FROM system.errors WHERE query_id = '$query_id' and code = 47") -lt 1 ]]; do
   retry=$((retry+1))
 
   if [ $retry -ge $max_retries ]; then