Skip the test for now

Author: pamarcos

tests/integration/test_storage_rabbitmq/test_failed_connection.py

@@ -172,9 +172,7 @@ def rabbitmq_monitor():
 
 # Tests
 
-timeout = 60
-
-
+@pytest.mark.skip(reason="Too flaky. Disable for now")
 def test_rabbitmq_restore_failed_connection_without_losses_1(rabbitmq_cluster, rabbitmq_monitor):
     """
     This test checks that after inserting through a RabbitMQ Engine, we can keep consuming from it
@@ -215,7 +213,7 @@ def test_rabbitmq_restore_failed_connection_without_losses_1(rabbitmq_cluster, r
 
     messages_num = 10000
     rabbitmq_monitor.set_expectations(published=messages_num, delivered=messages_num)
-    deadline = time.monotonic() + timeout
+    deadline = time.monotonic() + DEFAULT_TIMEOUT_SEC
     while time.monotonic() < deadline:
         try:
             instance.query(
@@ -229,18 +227,18 @@ def test_rabbitmq_restore_failed_connection_without_losses_1(rabbitmq_cluster, r
                 raise
     else:
         pytest.fail(
-            f"Time limit of {timeout} seconds reached. The query could not be executed successfully."
+            f"Time limit of {DEFAULT_TIMEOUT_SEC} seconds reached. The query could not be executed successfully."
         )
 
-    deadline = time.monotonic() + timeout
+    deadline = time.monotonic() + DEFAULT_TIMEOUT_SEC
     while time.monotonic() < deadline:
         number = int(instance.query("SELECT count() FROM test.view"))
         if number != 0:
             logging.debug(f"{number}/{messages_num} before suspending RabbitMQ")
             break
         time.sleep(0.1)
     else:
-        pytest.fail(f"Time limit of {timeout} seconds reached. The count is still 0.")
+        pytest.fail(f"Time limit of {DEFAULT_TIMEOUT_SEC} seconds reached. The count is still 0.")
 
     suspend_rabbitmq(rabbitmq_cluster, rabbitmq_monitor)
 
@@ -251,7 +249,7 @@ def test_rabbitmq_restore_failed_connection_without_losses_1(rabbitmq_cluster, r
 
     resume_rabbitmq(rabbitmq_cluster, rabbitmq_monitor)
 
-    deadline = time.monotonic() + timeout
+    deadline = time.monotonic() + DEFAULT_TIMEOUT_SEC
     while time.monotonic() < deadline:
         result = instance.query("SELECT count(DISTINCT key) FROM test.view")
         if int(result) == messages_num:
@@ -260,7 +258,7 @@ def test_rabbitmq_restore_failed_connection_without_losses_1(rabbitmq_cluster, r
         time.sleep(1)
     else:
         pytest.fail(
-            f"Time limit of {timeout} seconds reached. The result did not match the expected value."
+            f"Time limit of {DEFAULT_TIMEOUT_SEC} seconds reached. The result did not match the expected value."
         )
 
     instance.query(
@@ -275,6 +273,7 @@ def test_rabbitmq_restore_failed_connection_without_losses_1(rabbitmq_cluster, r
     )
 
 
+@pytest.mark.skip(reason="Too flaky. Disable for now")
 def test_rabbitmq_restore_failed_connection_without_losses_2(rabbitmq_cluster, rabbitmq_monitor):
     """
     This test checks that after inserting through a RabbitMQ Engine, we can keep consuming from it
@@ -306,7 +305,7 @@ def test_rabbitmq_restore_failed_connection_without_losses_2(rabbitmq_cluster, r
 
     messages_num = 10000
     rabbitmq_monitor.set_expectations(published=messages_num, delivered=messages_num)
-    deadline = time.monotonic() + timeout
+    deadline = time.monotonic() + DEFAULT_TIMEOUT_SEC
     while time.monotonic() < deadline:
         try:
             instance.query(
@@ -320,18 +319,18 @@ def test_rabbitmq_restore_failed_connection_without_losses_2(rabbitmq_cluster, r
                 raise
     else:
         pytest.fail(
-            f"Time limit of {timeout} seconds reached. The query could not be executed successfully."
+            f"Time limit of {DEFAULT_TIMEOUT_SEC} seconds reached. The query could not be executed successfully."
         )
 
-    deadline = time.monotonic() + timeout
+    deadline = time.monotonic() + DEFAULT_TIMEOUT_SEC
     while time.monotonic() < deadline:
         number = int(instance.query("SELECT count() FROM test.view"))
         if number != 0:
             logging.debug(f"{number}/{messages_num} before suspending RabbitMQ")
             break
         time.sleep(0.1)
     else:
-        pytest.fail(f"Time limit of {timeout} seconds reached. The count is still 0.")
+        pytest.fail(f"Time limit of {DEFAULT_TIMEOUT_SEC} seconds reached. The count is still 0.")
 
     suspend_rabbitmq(rabbitmq_cluster, rabbitmq_monitor)
 
@@ -348,7 +347,7 @@ def test_rabbitmq_restore_failed_connection_without_losses_2(rabbitmq_cluster, r
     # kill_rabbitmq()
     # revive_rabbitmq()
 
-    deadline = time.monotonic() + timeout
+    deadline = time.monotonic() + DEFAULT_TIMEOUT_SEC
     while time.monotonic() < deadline:
         result = instance.query("SELECT count(DISTINCT key) FROM test.view").strip()
         if int(result) == messages_num:
@@ -357,7 +356,7 @@ def test_rabbitmq_restore_failed_connection_without_losses_2(rabbitmq_cluster, r
         time.sleep(1)
     else:
         pytest.fail(
-            f"Time limit of {timeout} seconds reached. The result did not match the expected value."
+            f"Time limit of {DEFAULT_TIMEOUT_SEC} seconds reached. The result did not match the expected value."
         )
 
     instance.query(