Merge pull request ClickHouse#80293 from ClickHouse/clickhouse-local-extra-options

Allow extra options in `clickhouse-local` without the equality sign

Author: alexey-milovidov

src/Client/ClientBaseOptimizedParts.cpp

@@ -102,6 +102,10 @@ void ClientApplicationBase::parseAndCheckOptions(OptionsDescription & options_de
     /// Check positional options.
     for (const auto & op : parsed.options)
     {
+        /// Skip all options after empty `--`. These are processed separately into the Application configuration.
+        if (op.string_key.empty() && op.original_tokens[0].starts_with("--"))
+            break;
+
         if (!op.unregistered && op.string_key.empty() && !op.original_tokens[0].starts_with("--")
             && !op.original_tokens[0].empty() && !op.value.empty())
         {

tests/queries/0_stateless/03461_clickhouse_local_extra_options.reference

@@ -0,0 +1,2 @@
+666
+666

tests/queries/0_stateless/03461_clickhouse_local_extra_options.sh

@@ -0,0 +1,8 @@
+#!/usr/bin/env bash
+
+CURDIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
+# shellcheck source=../shell_config.sh
+. "$CURDIR"/../shell_config.sh
+
+${CLICKHOUSE_LOCAL} --query "SELECT getServerSetting('max_connections')" -- --max_connections=666
+${CLICKHOUSE_LOCAL} --query "SELECT getServerSetting('max_connections')" -- --max_connections 666