Merge pull request ClickHouse#79593 from yariks5s/caseWithExpression-arguments-fix

Forbid incorrect use-case for `CaseWithExpression`

Author: yariks5s

src/Functions/caseWithExpression.cpp

@@ -11,6 +11,7 @@ namespace DB
 namespace ErrorCodes
 {
     extern const int TOO_FEW_ARGUMENTS_FOR_FUNCTION;
+    extern const int BAD_ARGUMENTS;
 }
 
 namespace
@@ -38,6 +39,11 @@ class FunctionCaseWithExpression : public IFunction
         if (args.empty())
             throw Exception(ErrorCodes::TOO_FEW_ARGUMENTS_FOR_FUNCTION, "Function {} expects at least 1 arguments", getName());
 
+        /// We expect an even number of arguments, with the first argument being the expression,
+        /// and the last argument being the ELSE branch, with the rest being pairs of WHEN and THEN branches.
+        if (args.size() < 4 || args.size() % 2 != 0)
+            throw Exception(ErrorCodes::BAD_ARGUMENTS, "Function {} expects an even number of arguments: (expr, when1, then1, ..., else)", getName());
+
         /// See the comments in executeImpl() to understand why we actually have to
         /// get the return type of a transform function.
 

tests/queries/0_stateless/03390_non_constant_case.sql

@@ -35,7 +35,7 @@ END = 1;
 SELECT DISTINCT caseWithExpression(1.1, toNullable(0.1), 'a', 1.1, 'b', materialize(2.1), toFixedString('c', 1), 'default' ) AS f;
 
 SELECT
-    caseWithExpression(NULL, materialize(NULL), NULL) AS f1,
+    caseWithExpression(NULL, materialize(NULL), NULL, NULL) AS f1,
     if(NULL, toDateTimeOrZero(NULL), NULL) AS f2
 FROM numbers(1);
 

tests/queries/0_stateless/03444_case_with_expression_exception.reference

@@ -0,0 +1 @@
+SELECT caseWithExpression('C', 'A', true, 'B', false); -- { serverError BAD_ARGUMENTS }