Skip to content

Commit d0a0988

Browse files
committed
fix review + use boost wkt parsing + add new types
1 parent 1faeb19 commit d0a0988

File tree

5 files changed

+237
-131
lines changed

5 files changed

+237
-131
lines changed

src/Processors/Formats/Impl/ArrowColumnToCHColumn.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -483,15 +483,16 @@ static ColumnWithTypeAndName readColumnWithGeoData(const std::shared_ptr<arrow::
483483
auto * raw_data = buffer->mutable_data() + chunk.value_offset(offset_i);
484484
if (chunk.IsNull(offset_i))
485485
throw Exception(ErrorCodes::BAD_ARGUMENTS, "Geometry nullable columns are not supported");
486-
ReadBuffer in_buffer(reinterpret_cast<char*>(raw_data), chunk.value_length(offset_i), 0);
486+
487+
String in_data(reinterpret_cast<char*>(raw_data), chunk.value_length(offset_i));
487488
GeometricObject result_object;
488489
switch (geo_metadata.encoding)
489490
{
490491
case GeoEncoding::WKB:
491-
result_object = parseWKBFormat(in_buffer);
492+
result_object = parseWKBFormat(in_data);
492493
break;
493494
case GeoEncoding::WKT:
494-
result_object = parseWKTFormat(in_buffer);
495+
result_object = parseWKTFormat(in_data);
495496
break;
496497
}
497498
column_builder.appendObject(result_object);

0 commit comments

Comments
 (0)