remove unused API and pass string_view by value

Author: arthurpassos

src/Core/Block.cpp

@@ -290,7 +290,7 @@ const ColumnWithTypeAndName & Block::safeGetByPosition(size_t position) const
 }
 
 
-const ColumnWithTypeAndName * Block::findByName(const std::string_view & name, bool case_insensitive) const
+const ColumnWithTypeAndName * Block::findByName(std::string_view name, bool case_insensitive) const
 {
     if (case_insensitive)
     {

src/Core/Block.h

@@ -71,13 +71,7 @@ class Block
             const_cast<const Block *>(this)->findByName(name, case_insensitive));
     }
 
-    ColumnWithTypeAndName* findByName(const std::string_view & name, bool case_insensitive = false)
-    {
-        return const_cast<ColumnWithTypeAndName *>(
-            const_cast<const Block *>(this)->findByName(name, case_insensitive));
-    }
-
-    const ColumnWithTypeAndName * findByName(const std::string_view & name, bool case_insensitive) const;
+    const ColumnWithTypeAndName * findByName(std::string_view name, bool case_insensitive = false) const;
 
     const ColumnWithTypeAndName * findByName(const std::string & name, bool case_insensitive = false) const;
     std::optional<ColumnWithTypeAndName> findSubcolumnByName(const std::string & name) const;